tidy: remove trivial constructors

Also removed trivial destructors. Also removed clangd.log, a temporary file that was accidentally committed in #2507.
kuzudb · Nov 28, 2023 · d8c85a5 · d8c85a5
1 parent 85e7ae4
commit d8c85a5
Show file tree

Hide file tree

Showing 10 changed files with 6 additions and 29 deletions.
diff --git a/clangd.log b/clangd.log
diff --git a/src/include/binder/visitor/property_collector.h b/src/include/binder/visitor/property_collector.h
@@ -7,8 +7,6 @@ namespace binder {
 
 class PropertyCollector : public BoundStatementVisitor {
 public:
-    PropertyCollector() : BoundStatementVisitor() {}
-
     expression_vector getProperties();
 
 private:

diff --git a/src/include/common/serializer/reader.h b/src/include/common/serializer/reader.h
@@ -8,7 +8,7 @@ namespace common {
 class Reader {
 public:
     virtual void read(uint8_t* data, uint64_t size) = 0;
-    virtual ~Reader(){};
+    virtual ~Reader() = default;
 };
 
 } // namespace common

diff --git a/src/include/main/client_context.h b/src/include/main/client_context.h
@@ -7,6 +7,7 @@
 
 #include "common/timer.h"
 #include "main/kuzu_fwd.h"
+#include "transaction/transaction_context.h"
 
 namespace kuzu {
 
@@ -44,8 +45,6 @@ class ClientContext {
 public:
     explicit ClientContext(Database* database);
 
-    ~ClientContext();
-
     inline void interrupt() { activeQuery.interrupted = true; }
 
     bool isInterrupted() const { return activeQuery.interrupted; }

diff --git a/src/include/processor/operator/aggregate/base_aggregate.h b/src/include/processor/operator/aggregate/base_aggregate.h
@@ -14,7 +14,7 @@ class BaseAggregateSharedState {
 
     virtual std::pair<uint64_t, uint64_t> getNextRangeToRead() = 0;
 
-    ~BaseAggregateSharedState() {}
+    ~BaseAggregateSharedState() = default;
 
 protected:
     std::mutex mtx;

diff --git a/src/include/processor/operator/persistent/reader/parquet/resizable_buffer.h b/src/include/processor/operator/persistent/reader/parquet/resizable_buffer.h
@@ -9,7 +9,7 @@ namespace processor {
 
 class ByteBuffer { // on to the 10 thousandth impl
 public:
-    ByteBuffer(){};
+    ByteBuffer() = default;
     ByteBuffer(uint8_t* ptr, uint64_t len) : ptr{ptr}, len{len} {};
 
     uint8_t* ptr = nullptr;
@@ -59,7 +59,7 @@ class ByteBuffer { // on to the 10 thousandth impl
 
 class ResizeableBuffer : public ByteBuffer {
 public:
-    ResizeableBuffer() {}
+    ResizeableBuffer() = default;
     explicit ResizeableBuffer(uint64_t new_size) { resize(new_size); }
     void resize(uint64_t new_size) {
         len = new_size;

diff --git a/src/include/processor/operator/persistent/writer/parquet/string_column_writer.h b/src/include/processor/operator/persistent/writer/parquet/string_column_writer.h
@@ -20,8 +20,6 @@ using string_map_t = std::unordered_map<common::ku_string_t, T, StringHash, Stri
 
 class StringStatisticsState : public ColumnWriterStatistics {
 public:
-    StringStatisticsState() : hasStats(false), valuesTooBig(false), min(), max() {}
-
     bool hasStats;
     bool valuesTooBig;
     std::string min;

diff --git a/src/include/storage/buffer_manager/locked_queue.h b/src/include/storage/buffer_manager/locked_queue.h
@@ -9,8 +9,6 @@ class LockedQueue {
     std::queue<T> q;
 
 public:
-    LockedQueue() {}
-
     void enqueue(T x) {
         std::scoped_lock lck{mtx};
         q.push(std::move(x));

diff --git a/src/main/client_context.cpp b/src/main/client_context.cpp
@@ -29,8 +29,6 @@ ClientContext::ClientContext(Database* database)
     transactionContext = std::make_unique<TransactionContext>(database);
 }
 
-ClientContext::~ClientContext() {}
-
 void ClientContext::startTimingIfEnabled() {
     if (isTimeOutEnabled()) {
         activeQuery.timer.start();

diff --git a/src/main/connection.cpp b/src/main/connection.cpp
@@ -6,8 +6,8 @@
 #include "common/exception/connection.h"
 #include "main/database.h"
 #include "optimizer/optimizer.h"
-#include "parser//visitor/statement_read_write_analyzer.h"
 #include "parser/parser.h"
+#include "parser/visitor/statement_read_write_analyzer.h"
 #include "planner/operator/logical_plan_util.h"
 #include "planner/planner.h"
 #include "processor/plan_mapper.h"