tidy: force explicit constructors #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit constructors are better for performance and readability, in most cases. This check enforces them, everywhere.
acquamarin
approved these changes
Nov 28, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2507 +/- ##
==========================================
- Coverage 91.56% 91.56% -0.01%
==========================================
Files 1026 1026
Lines 37945 37947 +2
==========================================
Hits 34746 34746
- Misses 3199 3201 +2 ☔ View full report in Codecov by Sentry. |
Riolku
added a commit
that referenced
this pull request
Nov 28, 2023
Also removed trivial destructors. Also removed clangd.log, a temporary file that was accidentally committed in #2507.
Riolku
added a commit
that referenced
this pull request
Nov 28, 2023
Also removed trivial destructors. Also removed clangd.log, a temporary file that was accidentally committed in #2507.
Riolku
added a commit
that referenced
this pull request
Nov 28, 2023
Also removed trivial destructors. Also removed clangd.log, a temporary file that was accidentally committed in #2507.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit constructors are better for performance and readability, in most cases. This check enforces them, everywhere.