-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Linux and macOS CI runners to use Ninja build #2264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2264 +/- ##
==========================================
- Coverage 89.61% 89.48% -0.14%
==========================================
Files 1016 1021 +5
Lines 35806 36003 +197
==========================================
+ Hits 32089 32218 +129
- Misses 3717 3785 +68 ☔ View full report in Codecov by Sentry. |
We should probably use gmake in at least one of the jobs. I don't think it particularly matters which, but we should test that gmake still works. |
Benefit of doing it in GCC is build with ASAN and benchmark runs sooner. Benefit of doing it in clang means any clang tidy errors are shown earlier. |
I did not switch the benchmark to use ninja so gmake is being tested in benchmark. Is it sufficient or do you prefer to use gmake in a test? |
I think I'd rather have the benchmark use ninja and clang use gmake, because that should give us the fastest overall CI speeds. |
OK I will redeploy the benchmark runners some time and update this... |
@Riolku I have updated and redeployed the benchmark runners to use Ninja build and switched clang build job back to using gmake. I also removed several unneeded dependencies from the benchmark runner. |
@@ -255,19 +257,13 @@ jobs: | |||
benchmark: | |||
name: benchmark | |||
needs: [gcc-build-test, clang-build-test] | |||
env: | |||
NUM_THREADS: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use an env var, remove the parameter to make on the later line.
* Add ninja to Linux runners * Use Ninja in CI workflows * Update runner version * Update benchmark Dockerfile * Upgrade GitHub runner for benchmark * Add missing ninja-build * Revert CI benchmark dependencies
No description provided.