Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always write a whole page at a time when writing compressed data #2438

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

benjaminwinger
Copy link
Collaborator

A fix from #2408 which ended up breaking windows CI in #2304.

If data is compressed to 0 bytes, it would end up writing nothing, and if the data is at the end of the file the next time the file is opened it will read the number of pages as one less, triggering exceptions when attempting to read the last page.

Ideally we shouldn't be reading at all when data is compressed to nothing, but that can be addressed later.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb159fe) 90.44% compared to head (dbbc0e6) 90.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2438      +/-   ##
==========================================
- Coverage   90.44%   90.42%   -0.02%     
==========================================
  Files        1020     1020              
  Lines       36641    36640       -1     
==========================================
- Hits        33139    33133       -6     
- Misses       3502     3507       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit 0763648 into master Nov 17, 2023
12 checks passed
@benjaminwinger benjaminwinger deleted the file-end-fix branch November 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants