antlr4: suppress unused parameters #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANTLR4 generates code with unused parameters, which is incompatible with our recently added `-Wextra`. To combat this, we simply suppress the `-Wunused-parameter` warning when including the headers, since they are included so few times.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2559 +/- ##
==========================================
- Coverage 92.91% 92.90% -0.01%
==========================================
Files 1025 1025
Lines 38401 38401
==========================================
- Hits 35679 35676 -3
- Misses 2722 2725 +3 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANTLR4 generates code with unused parameters, which is incompatible with our recently added
-Wextra. To combat this, we simply suppress the-Wunused-parameterwarning when including the headers, since they are included so few times.