Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up execution context #2724

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Clean up execution context #2724

merged 1 commit into from
Jan 27, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jan 25, 2024

Removes the following fileds from executionContext:

    uint64_t numThreads;
    storage::MemoryManager* memoryManager;
    storage::BufferManager* bufferManager;
    common::VirtualFileSystem* vfs;
    main::Database* database;

Saves the database inside the clientContext.

src/include/main/client_context.h Outdated Show resolved Hide resolved
@acquamarin acquamarin force-pushed the clientContextRefactor branch 2 times, most recently from 5762ba6 to cceff2b Compare January 26, 2024 18:41
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (8ecc270) 93.44% compared to head (0eeabf8) 93.44%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/common/file_system/file_system.cpp 0.00% 6 Missing ⚠️
src/common/file_system/virtual_file_system.cpp 57.14% 6 Missing ⚠️
src/main/client_context.cpp 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2724      +/-   ##
==========================================
- Coverage   93.44%   93.44%   -0.01%     
==========================================
  Files        1073     1072       -1     
  Lines       40526    40544      +18     
==========================================
+ Hits        37869    37885      +16     
- Misses       2657     2659       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acquamarin acquamarin merged commit ca32518 into master Jan 27, 2024
28 of 29 checks passed
@acquamarin acquamarin deleted the clientContextRefactor branch January 27, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants