extension: enable building on Windows #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
windows-extension
branch
2 times, most recently
from
d94f7d1
to
7c56dad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2778 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 1087 1087
Lines 41860 41860
=======================================
Hits 39130 39130
Misses 2730 2730 ☔ View full report in Codecov by Sentry. |
Riolku
force-pushed
the
windows-extension
branch
9 times, most recently
from
9095bfb
to
e9b71fe
Compare
benjaminwinger
force-pushed
the
windows-extension
branch
from
97b0a3d
to
49f18ae
Compare
acquamarin
force-pushed
the
windows-extension
branch
from
515be71
to
37cd810
Compare
acquamarin
force-pushed
the
windows-extension
branch
from
37cd810
to
9e0f607
Compare
acquamarin
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires building extensions as a subproject of kuzu, since on Windows, we need to link against the static library.