Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export database #2853

Merged
merged 1 commit into from
Feb 15, 2024
Merged

export database #2853

merged 1 commit into from
Feb 15, 2024

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Feb 8, 2024

This is the initial pr of exporting the database. We can now support exporting the database into CSV files, along with copy cypher file, schema cypher file, and macro cypher file.

@hououou hououou marked this pull request as ready for review February 8, 2024 22:03
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (13bd5d5) 93.37% compared to head (a7eec0b) 93.41%.
Report is 37 commits behind head on master.

Files Patch % Lines
src/include/catalog/rdf_graph_schema.h 0.00% 2 Missing ⚠️
src/include/catalog/rel_table_group_schema.h 0.00% 2 Missing ⚠️
src/binder/bind/bind_export_database.cpp 97.72% 1 Missing ⚠️
src/catalog/catalog.cpp 80.00% 1 Missing ⚠️
src/planner/operator/logical_operator.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2853      +/-   ##
==========================================
+ Coverage   93.37%   93.41%   +0.04%     
==========================================
  Files        1090     1100      +10     
  Lines       42100    42352     +252     
==========================================
+ Hits        39310    39565     +255     
+ Misses       2790     2787       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/test_files/copy/export_db.test Outdated Show resolved Hide resolved
src/catalog/node_table_schema.cpp Outdated Show resolved Hide resolved
src/include/catalog/node_table_schema.h Outdated Show resolved Hide resolved
src/include/catalog/catalog.h Outdated Show resolved Hide resolved
src/include/common/string_utils.h Outdated Show resolved Hide resolved
src/include/processor/operator/persistent/export_db.h Outdated Show resolved Hide resolved
src/include/processor/operator/persistent/export_db.h Outdated Show resolved Hide resolved
src/include/processor/operator/persistent/export_db.h Outdated Show resolved Hide resolved
src/include/processor/operator/persistent/export_db.h Outdated Show resolved Hide resolved
scripts/antlr4/Cypher.g4.copy Show resolved Hide resolved
test/test_files/copy/export_db.test Outdated Show resolved Hide resolved
src/processor/map/CMakeLists.txt Outdated Show resolved Hide resolved
src/planner/plan/CMakeLists.txt Outdated Show resolved Hide resolved
src/parser/transform/CMakeLists.txt Outdated Show resolved Hide resolved
src/include/catalog/rel_table_schema.h Outdated Show resolved Hide resolved
src/include/processor/operator/physical_operator.h Outdated Show resolved Hide resolved
src/binder/bind/bind_export_database.cpp Outdated Show resolved Hide resolved
src/planner/plan/plan_db.cpp Outdated Show resolved Hide resolved
src/processor/map/map_db.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage of this PR is rather low. I would first clean unused code and then add more tests to achieve better coverage. If for some reason we cannot cover part of the code, we should document it clearly.

src/include/processor/operator/persistent/export_db.h Outdated Show resolved Hide resolved
src/include/catalog/table_schema.h Outdated Show resolved Hide resolved
src/include/planner/planner.h Outdated Show resolved Hide resolved
src/include/common/utils.h Outdated Show resolved Hide resolved
src/catalog/catalog.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_export_database.cpp Outdated Show resolved Hide resolved
src/include/binder/binder.h Outdated Show resolved Hide resolved
src/binder/bind/bind_export_database.cpp Outdated Show resolved Hide resolved
src/include/binder/binder.h Outdated Show resolved Hide resolved
src/include/binder/binder.h Outdated Show resolved Hide resolved
src/binder/bind/bind_export_database.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_export_database.cpp Outdated Show resolved Hide resolved
src/binder/bind/bind_export_database.cpp Outdated Show resolved Hide resolved
src/processor/operator/persistent/export_db.cpp Outdated Show resolved Hide resolved
src/catalog/rel_table_schema.cpp Outdated Show resolved Hide resolved
src/common/utils.cpp Outdated Show resolved Hide resolved
test/test_files/copy/export_db.test Show resolved Hide resolved
test/test_files/copy/export_db.test Outdated Show resolved Hide resolved
@hououou hououou merged commit 6283aa5 into master Feb 15, 2024
15 checks passed
@hououou hououou deleted the exprot_database branch February 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants