Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interactive-v1 benchmark #2858

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Create interactive-v1 benchmark #2858

merged 1 commit into from
Feb 15, 2024

Conversation

mxwli
Copy link
Contributor

@mxwli mxwli commented Feb 9, 2024

Added LDBC SNB Interactive v1 benchmark workflow that is manually triggered. Average runtime is about 10 minutes. Results for 0.2.0 can be found in the shared results spreadsheet.

Disabled queries:

  • Complex 1
  • Complex 5
  • Complex 8
  • Complex 10
  • Complex 13
  • Complex 14
  • Short 7

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a914765) 93.40% compared to head (00adefe) 93.38%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
- Coverage   93.40%   93.38%   -0.02%     
==========================================
  Files        1090     1089       -1     
  Lines       42104    42116      +12     
==========================================
+ Hits        39326    39329       +3     
- Misses       2778     2787       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxwli mxwli requested a review from ray6080 February 9, 2024 19:43
@ray6080 ray6080 requested a review from mewim February 12, 2024 01:52
@mxwli mxwli force-pushed the interactive-v1 branch 2 times, most recently from 64224dc to 5472784 Compare February 12, 2024 17:52
@mxwli
Copy link
Contributor Author

mxwli commented Feb 12, 2024

Changes to the script:

  1. Steps are more broken down. There is now Update Driver, Update Implementation, Load Database, Run Benchmark in place of just Run Benchmark
  2. The script now makes use of $SERIALIZED_DIR to keep persistent changes and prevent constantly cloning repositories.
  3. Data sets aren't grabbed every time they're required, and are now assumed to already exist on the machine.

@mxwli mxwli marked this pull request as ready for review February 14, 2024 14:56
@mxwli mxwli merged commit 7fc4519 into master Feb 15, 2024
15 checks passed
@mxwli mxwli deleted the interactive-v1 branch February 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants