Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cast functions #3016

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Refactor cast functions #3016

merged 1 commit into from
Mar 10, 2024

Conversation

andyfengHKU
Copy link
Contributor

Remove some if function name == CAST checking. The goal is to bind CAST as a regular scalar function. But some infrastructure is still missing.

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.26%. Comparing base (4692c54) to head (020c09b).

Files Patch % Lines
src/function/vector_cast_functions.cpp 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3016      +/-   ##
==========================================
- Coverage   93.26%   93.26%   -0.01%     
==========================================
  Files        1124     1125       +1     
  Lines       42953    42952       -1     
==========================================
- Hits        40061    40060       -1     
  Misses       2892     2892              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU force-pushed the refactor-cast-function-binding branch from e1b0005 to 020c09b Compare March 10, 2024 12:36
@andyfengHKU andyfengHKU merged commit dc9771f into master Mar 10, 2024
15 checks passed
@andyfengHKU andyfengHKU deleted the refactor-cast-function-binding branch March 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants