Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented Progress Bar #3051

Merged
merged 12 commits into from
Mar 18, 2024
Merged

Implemented Progress Bar #3051

merged 12 commits into from
Mar 18, 2024

Conversation

MSebanc
Copy link
Collaborator

@MSebanc MSebanc commented Mar 13, 2024

I have read and agree to the CLA of the Kuzu repository.

@MSebanc
Implemented progress bar for some source operators.
cc42898 
I have read and agree to the CLA of the Kuzu repository.
andyfengHKU
andyfengHKU reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that I didn't pick up from this draft is that at what frequency are we printing the progress bar. Maybe let's discuss that.

src/include/common/task_system/progress_bar.h Outdated Show resolved Hide resolved
src/processor/operator/scan_node_id.cpp Outdated Show resolved Hide resolved
src/processor/processor.cpp Outdated Show resolved Hide resolved
@MSebanc
Updated progress bar
2312ccd 
I have read and agree to the CLA of the Kuzu repository
andyfengHKU
andyfengHKU reviewed Mar 18, 2024
View reviewed changes
src/common/task_system/task.cpp Outdated Show resolved Hide resolved
src/include/processor/operator/scan_node_id.h Outdated Show resolved Hide resolved
src/include/processor/operator/scan_node_id.h Outdated Show resolved Hide resolved
src/include/processor/processor_task.h Outdated Show resolved Hide resolved
src/include/processor/processor_task.h Outdated Show resolved Hide resolved
@MSebanc
Updated NodeScanID progress based on feedback
df97aaf 
I have read and agree to the CLA of the Kuzu repository.
andyfengHKU
andyfengHKU approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't need to see this PR again. Just make sure you cleaned up the code and don't forget to leave some comment under ProgressBar.

src/processor/operator/scan_node_id.cpp Outdated Show resolved Hide resolved
src/include/main/client_context.h Outdated Show resolved Hide resolved
src/include/processor/operator/physical_operator.h Outdated Show resolved Hide resolved
@MSebanc
Updates based on comments
712de96 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Merging in main to branch
04e1a50 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
formatting
4cac57f 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
formatting
a2b3799 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Minor numNodes change
8cb6622 
I have read and agree to the CLA of the kuzu repository
@codecov Codecov
Copy link

codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 42.37288% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 92.88%. Comparing base (e7c6d73) to head (92dfa12).

Files Patch % Lines
src/common/task_system/progress_bar.cpp 20.00% 32 Missing ⚠️
src/include/common/task_system/progress_bar.h 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3051      +/-   ##
==========================================
- Coverage   92.94%   92.88%   -0.07%     
==========================================
  Files        1155     1157       +2     
  Lines       42919    42978      +59     
==========================================
+ Hits        39891    39919      +28     
- Misses       3028     3059      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSebanc
Fixed failing shell test
c658e27 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc marked this pull request as ready for review March 18, 2024 20:57
@MSebanc
Removed unused header
28047af 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Fixed shell test
9599c16 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Fixed shell tests
92dfa12 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc merged commit e963df1 into master Mar 18, 2024
16 of 17 checks passed
@MSebanc MSebanc deleted the progress-bar branch March 18, 2024 22:37
@andyfengHKU andyfengHKU mentioned this pull request Apr 15, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSebanc @andyfengHKU