feat(assets): remove assetId in upsert (#326)

* Updated typescript eslint parser
kuzzleio · Jan 16, 2024 · 2f286de · 2f286de
1 parent ac061e1
commit 2f286de
Show file tree

Hide file tree

Showing 4 changed files with 77 additions and 10 deletions.
diff --git a/lib/modules/asset/AssetService.ts b/lib/modules/asset/AssetService.ts
@@ -140,12 +140,12 @@ export class AssetService extends BaseService {
    */
   public async upsert(
     engineId: string,
-    assetId: string,
     model: string,
     reference: string,
     metadata: Metadata,
     request: KuzzleRequest
   ): Promise<KDocument<AssetContent>> {
+    const assetId = `${model}-${reference}`;
     return lock(`asset:${engineId}:${assetId}`, async () => {
       const asset = await this.get(engineId, assetId, request).catch(
         () => null

diff --git a/lib/modules/asset/AssetsController.ts b/lib/modules/asset/AssetsController.ts
@@ -138,14 +138,12 @@ export class AssetsController {
 
   async upsert(request: KuzzleRequest): Promise<ApiAssetUpsertResult> {
     const engineId = request.getString("engineId");
-    const assetId = request.getId();
     const model = request.getBodyString("model");
     const reference = request.getBodyString("reference");
     const metadata = request.getBodyObject("metadata");
 
     const upsertAsset = await this.assetService.upsert(
       engineId,
-      assetId,
       model,
       reference,
       metadata,

diff --git a/lib/modules/shared/services/BaseService.ts b/lib/modules/shared/services/BaseService.ts
@@ -2,7 +2,6 @@ import {
   ArgsDocumentControllerCreate,
   ArgsDocumentControllerDelete,
   ArgsDocumentControllerUpdate,
-  ArgsDocumentControllerUpsert,
   Backend,
   BaseRequest,
   DocumentSearchResult,

diff --git a/package-lock.json b/package-lock.json