Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(assets): remove assetId in upsert #326

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

Leagian
Copy link

@Leagian Leagian commented Jan 10, 2024

What does this PR do ?

This PR is an update of the previous one, the assetId has been removed to prevent displaying the _id in the API action. With this update, you can now perform updates or creations using only the model and reference.
example :

{
  "controller": "device-manager/assets",
  "action": "upsert",
  "engineId": "engine-ayse",
  "body": {
    "model": "Container",
    "reference": "linked1",
    "metadata": {
      "weight": 12,
      "height": 11
    }
  }
}

How should this be manually tested?

see above the api example

@Leagian Leagian changed the base branch from master to 2-dev January 10, 2024 15:17
@Leagian Leagian requested a review from rolljee January 10, 2024 15:18
@Leagian Leagian self-assigned this Jan 10, 2024
@Leagian Leagian merged commit aef54be into 2-dev Jan 16, 2024
3 checks passed
@Leagian Leagian deleted the KZLPRD-166-upsert-assets branch January 16, 2024 08:41
sebtiz13 pushed a commit that referenced this pull request Jan 16, 2024
* Removed assetId in upsert method

* Updated typescript eslint parser
sebtiz13 pushed a commit that referenced this pull request Jan 16, 2024
* Updated typescript eslint parser
@sebtiz13 sebtiz13 changed the title Kzlprd 166 upsert assets feat(assets) remove assetId in upsert Jan 16, 2024
@sebtiz13 sebtiz13 changed the title feat(assets) remove assetId in upsert feat(assets): remove assetId in upsert Jan 16, 2024
sebtiz13 pushed a commit that referenced this pull request Jan 16, 2024
* Updated typescript eslint parser
sebtiz13 pushed a commit that referenced this pull request Jan 16, 2024
# [2.4.0-beta.14](v2.4.0-beta.13...v2.4.0-beta.14) (2024-01-16)

### Bug Fixes

* **types:** correct repository data ([eee452a](eee452a))

### Features

* **assets:** remove assetId in upsert ([#326](#326)) ([2f286de](2f286de))
sebtiz13 pushed a commit that referenced this pull request Jan 16, 2024
# [2.4.0-beta.14](v2.4.0-beta.13...v2.4.0-beta.14) (2024-01-16)

### Bug Fixes

* **types:** correct repository data ([eee452a](eee452a))

### Features

* **assets:** remove assetId in upsert ([#326](#326)) ([2f286de](2f286de))
github-actions bot pushed a commit that referenced this pull request Mar 13, 2024
# [2.4.0-beta.14](v2.4.0-beta.13...v2.4.0-beta.14) (2024-03-13)

### Bug Fixes

* improve measure export to be usable with multiple measures in one measure ([#330](#330)) ([dab8d57](dab8d57))

### Features

* **assets:** remove assetId in upsert ([#326](#326)) ([2f286de](2f286de))
* implement comprehensible metadata ([#332](#332)) ([e80ef8e](e80ef8e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants