Fix Asset and Device creation from backend #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebouthinon
approved these changes
Jan 12, 2023
Comment on lines
44
to
52
| private get impersonatedSdk() { | ||
| return (user: User) => this.sdk.as(user, { checkRights: false }); | ||
| return (user: User) => { | ||
| if (user?._id) { | ||
| return this.sdk.as(user, { checkRights: false }); | ||
| } | ||
|
|
||
| return this.sdk; | ||
| }; | ||
| } |
There was a problem hiding this comment.
Since this is a very useful method should we provide it as well in the Framework?
There was a problem hiding this comment.
Well actually Kuzzle could just return the normal SDK if the user is null but I'm not sure about potential side effects for users who relied on the fact that the method will throw if an incorrect user is passed.
Also, I don't know where we could put this method in the framework. Let's see if we need it another time and talk about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Every modification of a Digital Twin (Asset or Device) through associated controllers is contextualized with the user who made the request to keep a trace in Kuzzle metadata.
This allows for example to know who has modified a metadata or link a new device to an asset by consulting history documents in
assets-historycollection.When a request is made to those controllers from the backend, there is no user since it's the EmbeddedSDK executing the request and it was causing an error.
This PR fix that, when the EmbeddedSDK is used to execute one of those action, it will use the user if the sdk was contextualized with sdk.as method, otherwise the metadata will be set with the
nulluser ID who represent the backend user.