-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Asset and Device creation from backend #252
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { Backend, Controller, KuzzleRequest } from "kuzzle"; | ||
import { ApiAssetCreateRequest, ApiAssetCreateResult } from "lib/modules/asset"; | ||
import { | ||
ApiDeviceCreateRequest, | ||
ApiDeviceCreateResult, | ||
} from "lib/modules/device"; | ||
|
||
export class TestsController extends Controller { | ||
constructor(app: Backend) { | ||
super(app); | ||
|
||
this.definition = { | ||
actions: { | ||
createDigitalTwinFromBackend: { | ||
handler: this.createDigitalTwinFromBackend, | ||
}, | ||
}, | ||
}; | ||
} | ||
|
||
async createDigitalTwinFromBackend(request: KuzzleRequest) { | ||
const engineId = request.getString("engineId"); | ||
const reference = request.getBodyString("reference"); | ||
|
||
await this.app.sdk.query<ApiAssetCreateRequest, ApiAssetCreateResult>({ | ||
controller: "device-manager/assets", | ||
action: "create", | ||
engineId, | ||
body: { | ||
model: "Container", | ||
reference, | ||
}, | ||
}); | ||
|
||
await this.app.sdk.query<ApiDeviceCreateRequest, ApiDeviceCreateResult>({ | ||
controller: "device-manager/devices", | ||
action: "create", | ||
engineId, | ||
body: { | ||
model: "DummyTemp", | ||
reference, | ||
}, | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a very useful method should we provide it as well in the Framework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well actually Kuzzle could just return the normal SDK if the
user
is null but I'm not sure about potential side effects for users who relied on the fact that the method will throw if an incorrect user is passed.Also, I don't know where we could put this method in the framework. Let's see if we need it another time and talk about this