ModelService upsert -> createOrReplace #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
Aschen
suggested changes
Mar 28, 2023
|
Done ! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
295
to
307
| response = await sdk.query({ | ||
| controller: "device-manager/models", | ||
| action: "writeDevice", | ||
| body: { | ||
| model: "Zigbee", | ||
| measures: [ | ||
| { type: "temperature", name: "temperature" }, | ||
| ], | ||
| metadataMappings: { | ||
| network2: { type: "keyword" }, | ||
| }, | ||
| }, | ||
| }); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
Comment on lines
92
to
105
| response = await sdk.query({ | ||
| controller: "device-manager/models", | ||
| action: "writeAsset", | ||
| body: { | ||
| engineGroup: "commons", | ||
| model: "Plane", | ||
| metadataMappings: { | ||
| company2: { type: "keyword" }, | ||
| }, | ||
| measures: [ | ||
| { name: "position", type: "position" }, | ||
| ], | ||
| }, | ||
| }); |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
fmauNeko
force-pushed
the
fix/model-controller-documentation-mismatch
branch
from
e4ae6ec
to
b90db79
Compare
fmauNeko
force-pushed
the
fix/model-controller-documentation-mismatch
branch
from
b90db79
to
76980e9
Compare
Merged
Aschen
added a commit
that referenced
this pull request
Apr 17, 2023
# [2.2.0](https://github.com/kuzzleio/kuzzle-device-manager/releases/tag/2.2.0) (2023-04-17) #### Bug fixes - [ [#290](#290) ] Historize asset for each same measurements ([tdislay](https://github.com/tdislay)) - [ [#288](#288) ] Full path nested metadata when create/update assets ([OlivierCavadenti](https://github.com/OlivierCavadenti)) - [ [#286](#286) ] ModelService upsert -> createOrReplace ([fmauNeko](https://github.com/fmauNeko)) - [ [#282](#282) ] Fix engine creation ([Aschen](https://github.com/Aschen)) #### New features - [ [#296](#296) ] Export measures to CSV ([Aschen](https://github.com/Aschen)) - [ [#291](#291) ] Add type of measure linked in each links of asset measures. ([OlivierCavadenti](https://github.com/OlivierCavadenti)) #### Enhancements - [ [#295](#295) ] Export default mappings ([Aschen](https://github.com/Aschen)) - [ [#293](#293) ] Allow JSONObject in metadata ([Aschen](https://github.com/Aschen)) - [ [#287](#287) ] Update metadata in existing assets when the model is modified ([fmauNeko](https://github.com/fmauNeko)) - [ [#283](#283) ] Store reason of discarded payloads ([OlivierCavadenti](https://github.com/OlivierCavadenti)) #### Others - [ [#289](#289) ] Split tsconfig for tests ([fmauNeko](https://github.com/fmauNeko)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR changes the
document.upsertcalls inModelServiceintodocument.createOrReplacecalls, in order to match the behavior described in the documentation.It also updates the related tests.