Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata in existing assets when the model is modified #287

Merged
merged 6 commits into from
Apr 13, 2023

Conversation

fmauNeko
Copy link
Contributor

@fmauNeko fmauNeko commented Mar 28, 2023

What does this PR do ?

This PR implements the propagation of any metadata addition / deletion on an asset model to the linked assets.

Fixes #277

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found 118 existing alerts. Please check the repository Security tab to see all alerts.

@fmauNeko fmauNeko force-pushed the feature/update-metadata-in-existing-assets branch 3 times, most recently from 7e79b94 to f5c9c8b Compare March 30, 2023 10:30
@fmauNeko fmauNeko marked this pull request as ready for review March 30, 2023 10:39
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/model/ModelService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/model/ModelService.ts Outdated Show resolved Hide resolved
lib/modules/model/ModelService.ts Outdated Show resolved Hide resolved
@fmauNeko fmauNeko force-pushed the feature/update-metadata-in-existing-assets branch from f5c9c8b to a9cf2dd Compare March 30, 2023 14:21
@fmauNeko fmauNeko force-pushed the feature/update-metadata-in-existing-assets branch from a9cf2dd to 658c288 Compare March 30, 2023 14:47
@fmauNeko fmauNeko force-pushed the feature/update-metadata-in-existing-assets branch from 2bc0541 to 453276a Compare April 7, 2023 07:02
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@tdislay tdislay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :>

lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
lib/modules/asset/AssetService.ts Outdated Show resolved Hide resolved
@fmauNeko fmauNeko requested review from Aschen and tdislay April 13, 2023 09:33
@fmauNeko fmauNeko merged commit ff88828 into 2-dev Apr 13, 2023
2 checks passed
@fmauNeko fmauNeko deleted the feature/update-metadata-in-existing-assets branch April 13, 2023 13:35
@Aschen Aschen mentioned this pull request Apr 17, 2023
Aschen added a commit that referenced this pull request Apr 17, 2023
# [2.2.0](https://github.com/kuzzleio/kuzzle-device-manager/releases/tag/2.2.0) (2023-04-17)


#### Bug fixes

- [ [#290](#290) ] Historize asset for each same measurements   ([tdislay](https://github.com/tdislay))
- [ [#288](#288) ] Full path nested metadata when create/update assets   ([OlivierCavadenti](https://github.com/OlivierCavadenti))
- [ [#286](#286) ] ModelService upsert -> createOrReplace   ([fmauNeko](https://github.com/fmauNeko))
- [ [#282](#282) ] Fix engine creation   ([Aschen](https://github.com/Aschen))

#### New features

- [ [#296](#296) ] Export measures to CSV   ([Aschen](https://github.com/Aschen))
- [ [#291](#291) ] Add type of measure linked in each links of asset measures.   ([OlivierCavadenti](https://github.com/OlivierCavadenti))

#### Enhancements

- [ [#295](#295) ] Export default mappings   ([Aschen](https://github.com/Aschen))
- [ [#293](#293) ] Allow JSONObject in metadata   ([Aschen](https://github.com/Aschen))
- [ [#287](#287) ] Update metadata in existing assets when the model is modified   ([fmauNeko](https://github.com/fmauNeko))
- [ [#283](#283) ] Store reason of discarded payloads   ([OlivierCavadenti](https://github.com/OlivierCavadenti))

#### Others

- [ [#289](#289) ] Split tsconfig for tests   ([fmauNeko](https://github.com/fmauNeko))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metadata in existing assets when the model is modified
4 participants