Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): wrong arguments in models' getDevice request #310

Merged
merged 8 commits into from
Jul 5, 2023

Conversation

Xamez
Copy link
Contributor

@Xamez Xamez commented Jun 20, 2023

What does this PR do ?

Fixes incorrect arguments in the request to retrieve a device's model.

ToDos

  • getAsset: wrong arguments & wrong controller & wrong slug route argument
  • getMeasure: wrong argument (type) & wrong slug route argument

@Xamez Xamez self-assigned this Jun 20, 2023
@GuinierRemi
Copy link
Contributor

Fixed both Todos, @tdislay can you please check ?

@GuinierRemi GuinierRemi requested a review from tdislay July 5, 2023 14:37
doc/2/controllers/models/get-device/index.md Outdated Show resolved Hide resolved
doc/2/controllers/models/get-device/index.md Outdated Show resolved Hide resolved
doc/2/controllers/models/get-measure/index.md Outdated Show resolved Hide resolved
doc/2/controllers/models/get-device/index.md Outdated Show resolved Hide resolved
GuinierRemi and others added 3 commits July 5, 2023 17:49
Co-authored-by: Théo Dislay <44380410+tdislay@users.noreply.github.com>
Co-authored-by: Théo Dislay <44380410+tdislay@users.noreply.github.com>
@GuinierRemi GuinierRemi merged commit ef413fb into 2-dev Jul 5, 2023
3 checks passed
@tdislay tdislay deleted the docs/fix-models-getDevice branch July 5, 2023 16:01
sebtiz13 pushed a commit that referenced this pull request Jul 24, 2023
Fixes incorrect arguments in the request to retrieve a device's model.

---------

Co-authored-by: Rémi <97107909+GuinierRemi@users.noreply.github.com>
Co-authored-by: Théo Dislay <44380410+tdislay@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
# [2.3.0](v2.2.8...v2.3.0) (2023-08-14)

### Bug Fixes

* composite measures should be correctly exported to CSV ([#309](#309)) ([487c1e8](487c1e8))
* **docs:** wrong arguments in models' getDevice request ([#310](#310)) ([028c65c](028c65c))

### Features

* **assetGroups:** add assetGroups roles ([b9d0fae](b9d0fae))
* **assetGroups:** add groups for assets ([#306](#306)) ([10de8b4](10de8b4))
* **assetGroups:** add lastUpdate on changes  ([#311](#311)) ([36a4575](36a4575))
* **semantic-release:** add semantic release support to device manager ([99b1683](99b1683))
github-actions bot pushed a commit that referenced this pull request Aug 14, 2023
# [2.3.0](v2.2.8...v2.3.0) (2023-08-14)

### Bug Fixes

* composite measures should be correctly exported to CSV ([#309](#309)) ([487c1e8](487c1e8))
* **docs:** wrong arguments in models' getDevice request ([#310](#310)) ([028c65c](028c65c))

### Features

* **assetGroups:** add assetGroups roles ([b9d0fae](b9d0fae))
* **assetGroups:** add groups for assets ([#306](#306)) ([10de8b4](10de8b4))
* **assetGroups:** add lastUpdate on changes  ([#311](#311)) ([36a4575](36a4575))
* **semantic-release:** add semantic release support to device manager ([99b1683](99b1683))
sebtiz13 pushed a commit that referenced this pull request Aug 14, 2023
# [2.3.0](v2.2.8...v2.3.0) (2023-08-14)

### Bug Fixes

* composite measures should be correctly exported to CSV ([#309](#309)) ([487c1e8](487c1e8))
* **docs:** wrong arguments in models' getDevice request ([#310](#310)) ([028c65c](028c65c))

### Features

* **assetGroups:** add assetGroups roles ([b9d0fae](b9d0fae))
* **assetGroups:** add groups for assets ([#306](#306)) ([10de8b4](10de8b4))
* **assetGroups:** add lastUpdate on changes  ([#311](#311)) ([36a4575](36a4575))
* **semantic-release:** add semantic release support to device manager ([99b1683](99b1683))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants