Fix composite measures should be correctly exported to CSV #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 11, 2023 16:33
fmauNeko
approved these changes
Jun 13, 2023
thomas-mauran
approved these changes
Jun 13, 2023
sebtiz13
requested changes
Jun 13, 2023
Comment on lines
+24
to
+29
| name: "ask:device-manager:model:measure:get"; | ||
|
|
||
| payload: { type: string }; | ||
|
|
||
| result: MeasureModelContent; | ||
| }; |
There was a problem hiding this comment.
Nit-picking, why blank lines here ?
There was a problem hiding this comment.
Idk, it was already done this way..
But I'm curious about it 🤔 ..
Comment on lines
278
to
280
| const header = `${name}${ | ||
| pathWithoutType !== "" ? `.${pathWithoutType}` : "" | ||
| }`; |
There was a problem hiding this comment.
Suggested change
| const header = `${name}${ | |
| pathWithoutType !== "" ? `.${pathWithoutType}` : "" | |
| }`; | |
| const header = `${name}.${pathWithoutType}`; |
This ternary condition seems to be useless.
Unless if you want to handle nullish value in this case you have an error and the better solution is to use nullish coalsing, like pathWithoutType ?? ''
There was a problem hiding this comment.
You're not entirely right, it was useful, but your comment made me rework this crap.
I've fixed it. I now use a simple regex to do what I wanted to do.
I will add a comment in this PR explaining what I did
|
Following my response to Seb's comment. When I implemented this fix, I assumed that we should not repeat the type of a measure in the column header. What's actually going on is this: Do you guys, think this should not be this way ? |
tdislay
force-pushed
the
fix/export-correctly-composite-measures
branch
from
d63b92a
to
7692786
Compare
sebtiz13
approved these changes
Jun 14, 2023
sebtiz13
pushed a commit
that referenced
this pull request
Jul 24, 2023
* refactor: add acceleration measure to the DummyTemp Decoder * fix: test name * test: implement failing tests * feat: add an ask event to retrieve the content of a measure * feat: generate a measure column for each property of a measure * fix: position needs to be the first property for consistency purposes * fix: failing test * refactor: more proper way of computing header string --------- Co-authored-by: Théo Dislay <tdislay@kuzzle.io>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
# [2.3.0](v2.2.8...v2.3.0) (2023-08-14) ### Bug Fixes * composite measures should be correctly exported to CSV ([#309](#309)) ([487c1e8](487c1e8)) * **docs:** wrong arguments in models' getDevice request ([#310](#310)) ([028c65c](028c65c)) ### Features * **assetGroups:** add assetGroups roles ([b9d0fae](b9d0fae)) * **assetGroups:** add groups for assets ([#306](#306)) ([10de8b4](10de8b4)) * **assetGroups:** add lastUpdate on changes ([#311](#311)) ([36a4575](36a4575)) * **semantic-release:** add semantic release support to device manager ([99b1683](99b1683))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
# [2.3.0](v2.2.8...v2.3.0) (2023-08-14) ### Bug Fixes * composite measures should be correctly exported to CSV ([#309](#309)) ([487c1e8](487c1e8)) * **docs:** wrong arguments in models' getDevice request ([#310](#310)) ([028c65c](028c65c)) ### Features * **assetGroups:** add assetGroups roles ([b9d0fae](b9d0fae)) * **assetGroups:** add groups for assets ([#306](#306)) ([10de8b4](10de8b4)) * **assetGroups:** add lastUpdate on changes ([#311](#311)) ([36a4575](36a4575)) * **semantic-release:** add semantic release support to device manager ([99b1683](99b1683))
sebtiz13
pushed a commit
that referenced
this pull request
Aug 14, 2023
# [2.3.0](v2.2.8...v2.3.0) (2023-08-14) ### Bug Fixes * composite measures should be correctly exported to CSV ([#309](#309)) ([487c1e8](487c1e8)) * **docs:** wrong arguments in models' getDevice request ([#310](#310)) ([028c65c](028c65c)) ### Features * **assetGroups:** add assetGroups roles ([b9d0fae](b9d0fae)) * **assetGroups:** add groups for assets ([#306](#306)) ([10de8b4](10de8b4)) * **assetGroups:** add lastUpdate on changes ([#311](#311)) ([36a4575](36a4575)) * **semantic-release:** add semantic release support to device manager ([99b1683](99b1683))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Composite measures (measures with multiple properties, which can be objects) are now correctly exported. Before, only the property with the name equal to the measure type was exported (see the issue below).
Fixes #308.
Other changes
valueMappingsfor the position measurement. It helps with consistency (which means, we do not need to sort properties from the mappings to display in a logical order the columns in the csv export).Boyscout