Add endpoint configuration option that can be used by s3-API compatib… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aschen
suggested changes
Nov 7, 2019
Aschen
approved these changes
Nov 7, 2019
|
Perfect ! I wait for the CI and after I will merge it into the main repository ;-) |
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Merged
Aschen
added a commit
that referenced
this pull request
Nov 28, 2019
# [2.0.1](https://github.com/kuzzleio/kuzzle-plugin-s3/releases/tag/2.0.1) (2019-11-28) #### Others - [ [#8](#8) ] Add endpoint configuration option that can be used by s3-API compatib… ([gpulido](https://github.com/gpulido)) ---
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable to use endpoints configuration variables instead of a fixed region so any S3 compatible service that uses it (like minio) can be used as direct reemplacement of amazon S3. This allows to add a selfhosting files capabilities.
How should this be manually tested?
Configure the plugin to use endpoint: https://yourminion.example.com:port.