Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dockerhub] Fix docker image builder #1216

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Conversation

alexandrebouthinon
Copy link
Member

@alexandrebouthinon alexandrebouthinon commented Nov 14, 2018

What does this PR do ?

Use script to build docker images only on *-dev branches. For master branch and releases, use automated build on dockerhub

Finally, this PR will fix the bash script used to build kuzzle images.

How should this be manually tested?

Check Travis file

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #1216 into 1-dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            1-dev    #1216   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          95       95           
  Lines        6555     6555           
=======================================
  Hits         6154     6154           
  Misses        401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e3825...bf68057. Read the comment docs.

Copy link
Contributor

@Aschen Aschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure ? Dockerhub does not handle multistage build, so how it can build our production images ?
We are supposed to build 2 images with a single Dockerfile: kuzzleio/kuzzle and kuzzleio/plugin-dev

@alexandrebouthinon alexandrebouthinon changed the title [dockerhub] Use script to build only on *-dev [dockerhub] Fix docker image builder Nov 15, 2018
@alexandrebouthinon alexandrebouthinon merged commit 0ae295b into 1-dev Nov 15, 2018
@alexandrebouthinon alexandrebouthinon deleted the fix-dockerhub branch November 15, 2018 21:36
@benoitvidis benoitvidis mentioned this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants