Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for socket.io #1489

Merged
merged 28 commits into from
Oct 17, 2019
Merged

Drop support for socket.io #1489

merged 28 commits into from
Oct 17, 2019

Conversation

scottinet
Copy link
Contributor

⚠️ depends on #1484

Description

Drop support for socket.io (at last)

scottinet and others added 27 commits September 5, 2019 14:42
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
@scottinet scottinet added changelog:breaking-changes Increase the major version number 2.x labels Oct 11, 2019
@scottinet scottinet self-assigned this Oct 11, 2019
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #1489 into 2-dev will increase coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2-dev    #1489      +/-   ##
==========================================
+ Coverage   92.82%   92.83%   +<.01%     
==========================================
  Files          98       97       -1     
  Lines        6678     6600      -78     
==========================================
- Hits         6199     6127      -72     
+ Misses        479      473       -6
Impacted Files Coverage Δ
lib/api/core/entrypoints/clientConnection.js 100% <ø> (ø) ⬆️
...i/core/storage/bootstrap/internalIndexBootstrap.js 97.5% <0%> (ø) ⬆️
lib/api/core/entrypoints/index.js 98.88% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b72934...405fd88. Read the comment docs.

@Aschen Aschen merged commit e8e6237 into 2-dev Oct 17, 2019
@Aschen Aschen deleted the remove-socketio branch October 17, 2019 07:49
@Aschen Aschen mentioned this pull request Nov 5, 2019
Aschen added a commit that referenced this pull request Nov 5, 2019
# [2.0.0-rc.2](https://github.com/kuzzleio/kuzzle/releases/tag/2.0.0-rc.2) (2019-11-05)


#### Breaking changes

- [ [#1500](#1500) ] Remove Dsl constructor from plugin context   ([Aschen](https://github.com/Aschen))
- [ [#1489](#1489) ] Drop support for socket.io   ([scottinet](https://github.com/scottinet))
- [ [#1491](#1491) ] Remove strategy constructors support   ([Aschen](https://github.com/Aschen))
- [ [#1476](#1476) ] Change Document controller m* routes returns & fix SDK functional tests   ([Aschen](https://github.com/Aschen))

#### Bug fixes

- [ [#1512](#1512) ] Fix subscribing with a dead connection   ([benoitvidis](https://github.com/benoitvidis))
- [ [#1507](#1507) ] Properly destroy a user after a credentials creation failure   ([scottinet](https://github.com/scottinet))
- [ [#1483](#1483) ] Fix socketio connections leak & deactivate this protocol by default   ([scottinet](https://github.com/scottinet))

#### New features

- [ [#1502](#1502) ] Add a new "document:exists" API route   ([scottinet](https://github.com/scottinet))
- [ [#1501](#1501) ] Add collection delete   ([Aschen](https://github.com/Aschen))
- [ [#1499](#1499) ] Expose an Elasticsearch client constructor in plugin context   ([Aschen](https://github.com/Aschen))
- [ [#1484](#1484) ] Upgrade script   ([scottinet](https://github.com/scottinet))

#### Enhancements

- [ [#1510](#1510) ] Mapping - enable dynamic templates   ([benoitvidis](https://github.com/benoitvidis))
- [ [#1495](#1495) ] Check for SDK compatibility against current Kuzzle version   ([Aschen](https://github.com/Aschen))
- [ [#1498](#1498) ] Add highlight to search results   ([Aschen](https://github.com/Aschen))
- [ [#1488](#1488) ] Add kuzzle version to the dumped informations   ([scottinet](https://github.com/scottinet))
- [ [#1481](#1481) ] Error codes normalization   ([scottinet](https://github.com/scottinet))
- [ [#1478](#1478) ] Error codes redux   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x changelog:breaking-changes Increase the major version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants