Fix socketio connections leak & deactivate this protocol by default #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottinet
changed the title
Codecov Report
@@ Coverage Diff @@
## 2-dev #1483 +/- ##
==========================================
- Coverage 92.64% 92.63% -0.01%
==========================================
Files 98 98
Lines 6637 6644 +7
==========================================
+ Hits 6149 6155 +6
- Misses 488 489 +1
Continue to review full report at Codecov.
|
Aschen
approved these changes
Oct 2, 2019
alexandrebouthinon
approved these changes
Oct 2, 2019
Merged
Aschen
added a commit
that referenced
this pull request
Nov 5, 2019
# [2.0.0-rc.2](https://github.com/kuzzleio/kuzzle/releases/tag/2.0.0-rc.2) (2019-11-05) #### Breaking changes - [ [#1500](#1500) ] Remove Dsl constructor from plugin context ([Aschen](https://github.com/Aschen)) - [ [#1489](#1489) ] Drop support for socket.io ([scottinet](https://github.com/scottinet)) - [ [#1491](#1491) ] Remove strategy constructors support ([Aschen](https://github.com/Aschen)) - [ [#1476](#1476) ] Change Document controller m* routes returns & fix SDK functional tests ([Aschen](https://github.com/Aschen)) #### Bug fixes - [ [#1512](#1512) ] Fix subscribing with a dead connection ([benoitvidis](https://github.com/benoitvidis)) - [ [#1507](#1507) ] Properly destroy a user after a credentials creation failure ([scottinet](https://github.com/scottinet)) - [ [#1483](#1483) ] Fix socketio connections leak & deactivate this protocol by default ([scottinet](https://github.com/scottinet)) #### New features - [ [#1502](#1502) ] Add a new "document:exists" API route ([scottinet](https://github.com/scottinet)) - [ [#1501](#1501) ] Add collection delete ([Aschen](https://github.com/Aschen)) - [ [#1499](#1499) ] Expose an Elasticsearch client constructor in plugin context ([Aschen](https://github.com/Aschen)) - [ [#1484](#1484) ] Upgrade script ([scottinet](https://github.com/scottinet)) #### Enhancements - [ [#1510](#1510) ] Mapping - enable dynamic templates ([benoitvidis](https://github.com/benoitvidis)) - [ [#1495](#1495) ] Check for SDK compatibility against current Kuzzle version ([Aschen](https://github.com/Aschen)) - [ [#1498](#1498) ] Add highlight to search results ([Aschen](https://github.com/Aschen)) - [ [#1488](#1488) ] Add kuzzle version to the dumped informations ([scottinet](https://github.com/scottinet)) - [ [#1481](#1481) ] Error codes normalization ([scottinet](https://github.com/scottinet)) - [ [#1478](#1478) ] Error codes redux ([scottinet](https://github.com/scottinet)) ---
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #1482 , with the following additional change: the socketio protocol is now deactivated by default (files
default.config.jsand.kuzzlerc.sample)