Add server:capabilities api action #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2-dev #2242 +/- ##
==========================================
- Coverage 92.47% 92.34% -0.13%
==========================================
Files 124 124
Lines 8190 8234 +44
==========================================
+ Hits 7574 7604 +30
- Misses 616 630 +14
Continue to review full report at Codecov.
|
Aschen
suggested changes
Jan 3, 2022
Aschen
suggested changes
Jan 3, 2022
Aschen
suggested changes
Jan 7, 2022
Aschen
suggested changes
Jan 7, 2022
Aschen
suggested changes
Jan 9, 2022
Shiranuit
approved these changes
Jan 12, 2022
Aschen
suggested changes
Jan 21, 2022
Aschen
suggested changes
Jan 28, 2022
Comment on lines
80
to
81
| this._info.elasticsearch = await global.kuzzle.ask('core:storage:public:info:get'); | ||
| this._info.redis = await global.kuzzle.ask('core:cache:public:info:get'); |
There was a problem hiding this comment.
Those promise should be made in //
Aschen
suggested changes
Feb 4, 2022
Aschen
suggested changes
Feb 4, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Aschen
approved these changes
Feb 5, 2022
Closed
Aschen
added
changelog:new-features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Exposing specific properties to the configuration because
server:getConfig/server:infogive too much info. We want a less verbose API action.With the following information:
How should this be manually tested?
Start Kuzzle with
docker-compose up, then with kourou use the capabilities action:kourou server:capabilitiesor send GET request to the routehttp:localhost:7512/_capabilitiesroute.