Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI, travis version, documentation version and snippets on 3-dev #274

Merged
merged 7 commits into from
Nov 16, 2020

Conversation

Shiranuit
Copy link
Contributor

@Shiranuit Shiranuit commented Nov 12, 2020

What does this PR do?

  • Fix CI docker-compose that was working with Kuzzle V1 and not Kuzzle V2
  • Update doc snippets version from 1 to 3
  • Fix snippets that were broken, and not detected because of a bug in the CI docker-compose
  • Update travis version from 1.14.x to 1.15.x

@Shiranuit Shiranuit self-assigned this Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #274 (5e9fc1b) into 3-dev (26bf670) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            3-dev     #274      +/-   ##
==========================================
+ Coverage   89.58%   89.71%   +0.12%     
==========================================
  Files         240      241       +1     
  Lines        4024     4034      +10     
==========================================
+ Hits         3605     3619      +14     
+ Misses        367      365       -2     
+ Partials       52       50       -2     
Impacted Files Coverage Δ
collection/refresh.go 100.00% <100.00%> (ø)
collection/update_specifications.go 100.00% <100.00%> (+9.09%) ⬆️
collection/validate_specifications.go 71.42% <100.00%> (+3.42%) ⬆️
document/update.go 100.00% <100.00%> (ø)
index/mDelete.go 90.90% <100.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26bf670...5e9fc1b. Read the comment docs.

@Shiranuit Shiranuit changed the title Fix CI 3-dev Fix CI, travis version, documentation version and snippets on 3-dev Nov 13, 2020
@Shiranuit Shiranuit removed the wip label Nov 13, 2020
@jenow jenow merged commit 624c309 into 3-dev Nov 16, 2020
@jenow jenow deleted the fix-ci branch November 16, 2020 14:17
@Yoann-Abbes Yoann-Abbes mentioned this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants