volatile data can also be null #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6.x #286 +/- ##
=======================================
Coverage 80.27% 80.27%
=======================================
Files 19 19
Lines 2023 2023
=======================================
Hits 1624 1624
Misses 399 399
Continue to review full report at Codecov.
|
benoitvidis
suggested changes
Mar 5, 2018
| @@ -212,7 +212,7 @@ class RTWrapper extends KuzzleEventEmitter { | |||
| return cb(error); | |||
| } | |||
| this.on(response.result.channel, data => { | |||
| data.fromSelf = data.volatile !== undefined && data.volatile.sdkInstanceId === this.id; | |||
| data.fromSelf = data.volatile !== undefined && data.volatile !== null && data.volatile.sdkInstanceId === this.id; | |||
There was a problem hiding this comment.
is there any chance data.volatile can be a scalar?
There was a problem hiding this comment.
No, the RequestInput object forbids it: https://github.com/kuzzleio/kuzzle-common-objects/blob/master/lib/models/requestInput.js#L249
benoitvidis
approved these changes
Mar 9, 2018
| @@ -212,7 +212,7 @@ class RTWrapper extends KuzzleEventEmitter { | |||
| return cb(error); | |||
| } | |||
| this.on(response.result.channel, data => { | |||
| data.fromSelf = data.volatile !== undefined && data.volatile.sdkInstanceId === this.id; | |||
| data.fromSelf = data.volatile !== undefined && data.volatile !== null && data.volatile.sdkInstanceId === this.id; | |||
ballinette
pushed a commit
that referenced
this pull request
Mar 29, 2018
ballinette
pushed a commit
that referenced
this pull request
Jun 5, 2018
* index controller * server controller * collection controller * document controller * wip * wip * wip - http * rc - wo tests * fix vars scope * tests - collection * tests ms * nitpicking * re-add package-lock.json (previously removed by error by #286) * ServerController: add jsdocs * ServerController: add getStats method * fix request.refresh argument * inject kuzzle's volatile into requests * remove defaultIndex * remove obsolete unit tests on removed features * unit-tests on security objects * Refactor unit-tests for network protocols and query management * refactor unit-tests for Kuzzle constructor, getters and setters * fix kuzzle.connect unit tests * fix unit tests for kuzzle eventEmitter/listener management * fix unit tests for Kuzze netowrk methods * fix unit tests for kuzzle query management * fix linter * fix unit-test for memoryStorage controller * fix unit tests for auth controller * remove obsolete mock * fix unit test for bulk controller * fix unit-test for collection controller * improve naming for unit test groups * unit-tests for server controller * typo * unit tests for document controller * unit tests for index controller * factorize security objects contructors * nitpicking * add unit tests for security controller * add unit tests for DocumentSearchResult class * add unit tests for SpecificationsSearchResult class * add hits array to searchResult objects * add unit tests for ProfileSearchResult class * add unit tests for UserSearchResult class * add unit tests for RoleSearchResult class * add unit tests for RealTime controller and Room class * harmonize error rejections (use throw instead of Promise.reject)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking if a
sdkInstanceidentifier is present in volatile data, we first check whether volatiles are defined or not. But they can also be null, leading to a sdk crash when that happens.This PR fixes that issue.