Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: RON and --release everywhere #66

Merged
merged 1 commit into from Jan 7, 2019
Merged

README.md: RON and --release everywhere #66

merged 1 commit into from Jan 7, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Jan 6, 2019

No description provided.

@kvark
Copy link
Owner

kvark commented Jan 7, 2019

@suhr Thank you for the PR!
I think we should omit --release, in fact, since as of #60 we are fast enough that Debug doesn't harm nearly as much.

@suhr
Copy link
Contributor Author

suhr commented Jan 7, 2019

Even for road?

@kvark
Copy link
Owner

kvark commented Jan 7, 2019

Sure, we aren't at the stage where it matters (i.e. game is playable with many players) anyway, yet.

kvark
kvark approved these changes Jan 7, 2019
View reviewed changes
Copy link
Owner

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
bors r+

bors bot added a commit that referenced this pull request Jan 7, 2019
@bors @suhr
Merge #66
cfa4ad1 
66: README.md: RON and `--release` everywhere r=kvark a=suhr



Co-authored-by: Сухарик <suhr@i2pmail.org>
@bors
Copy link
Contributor

bors bot commented Jan 7, 2019

Build succeeded

@bors bors bot merged commit ee50326 into kvark:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suhr @kvark