exec version #2
exec version #2
Conversation
added use of standard os.path.pathsep
content of python.py)
- python header uses `evn python`
|
|
||
| def inject_pythonpath(): | ||
| ''' | ||
| insert virtualevn path into pythonpath | ||
| ''' | ||
| pathdelim = sys.platform == 'win32' and ';' or ':' |
There was a problem hiding this comment.
There is alreadyos.path.pathsep for this purpose (tested on Linux yet, but should work on Win and Mac too).
|
wonderful! thank you @czervenka i will run the test suite on windows and some older pythons and let you know. i'd really like to merge this stuff! didn't know about |
|
I realized that Win needs special quoting for arguments with spaces. All tests passed on WindowsXP/python2.7 now. |
|
hey, so |
|
We have tried this version in our preproduction environment. I can confirm that there are no problems running daemontools rvirtualenv gunicorn with this "exec" version. |
|
@czervenka that's wonderfull news. thank you. i will have a quick look at #5 and do the release as soon as possible. |
|
but i believe this is ok. |
I have replaced
system()call by python'sexec()in templates/bin/python.py. This version of script si simpler, nicer and does work with programs like daemon tools, eclipse debugger, etc. There is no need for parsing arguments and also no extra useless process hanging in memory.Tests were ok.