Add quit request timeout #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure scuttle does not hang on sending quit requests (especially relevant if also providing a generic quit endpoint) a timeout can be provided. When a request fails or times out, it is logged (if enabled) but scuttle will exit cleanly and timely. By default, the QUIT_REQUEST_TIMEOUT is set to 5 seconds. When multiple generic quit endpoints are provided they are now called in parallel to ensure the timeout is guaranteeing a quick shutdown of scuttle.
Also added a concurrency safe request counter to check if a request has been made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure scuttle does not hang on sending quit requests (especially
relevant if also providing a generic quit endpoint) a timeout can be
provided. When a request fails or times out, it is logged (if enabled)
but scuttle will exit cleanly and timely.
By default, the QUIT_REQUEST_TIMEOUT is set to 5 seconds.
When multiple generic quit endpoints are provided they are now called in
parallel to ensure the timeout is guaranteeing a quick shutdown of
scuttle.