Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quit request timeout #18

Merged
merged 2 commits into from
Oct 1, 2023
Merged

Add quit request timeout #18

merged 2 commits into from
Oct 1, 2023

Commits on Oct 1, 2023

  1. Add quit request timeout 

    To ensure scuttle does not hang on sending quit requests (especially
relevant if also providing a generic quit endpoint) a timeout can be
provided. When a request fails or times out, it is logged (if enabled)
but scuttle will exit cleanly and timely.
By default, the QUIT_REQUEST_TIMEOUT is set to 5 seconds.

When multiple generic quit endpoints are provided they are now called in
parallel to ensure the timeout is guaranteeing a quick shutdown of
scuttle.
    @kvij
    kvij committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    4c27cdb View commit details
    Browse the repository at this point in the history

  2. Test for quit request timeout 

    Also added a concurrency safe request counter to check if a request has
been made.
    @kvij
    kvij committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    9445295 View commit details
    Browse the repository at this point in the history