Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [Not]Contains assertions & corresponding [Not]Found failures. #98

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

matthieu-vergne
Copy link
Contributor

@matthieu-vergne matthieu-vergne commented Oct 28, 2018

Here I add the assertContains asked in #59.
It is quite different from #96:

  • I go further in terms of renaming, with proper container and content names ;
  • Parameters are container first, content second, while Add assertContains function - #59 #96 is the reverse ;
  • I don't use od because I am not familiar with it and multi-line was not part of my use cases. Maybe good to add ;
  • I also add assertNotContains for the symetry ;
  • I also add failFound and failNotFound ;

Copy link
Owner

@kward kward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull!

@kward kward merged commit 69f3889 into kward:master Nov 6, 2018
@matthieu-vergne
Copy link
Contributor Author

Thank you for accepting it. {^_^}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants