Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kw ssh must handle the first ssh connection #610

Closed
rodrigosiqueira opened this issue May 23, 2022 · 0 comments
Closed

kw ssh must handle the first ssh connection #610

rodrigosiqueira opened this issue May 23, 2022 · 0 comments
Labels
deploy done: wait for stable This issue was done, but we are waiting to push it for the master branch. enhancement New feature or request good first issue Good for newcomers

Comments

@rodrigosiqueira
Copy link
Collaborator

Description:

The IP might change when we have a test machine connected to a very simple local network. However, even if you update kworkflow.config file to reflect the new change, you will see this message:

We could not reach the remote machine by using:
 IP: IP
 User: root
 Port: 22
Please ensure that the above info is correct.
Suggestion: Check if your remote machine permits root login via ssh
or check if your public key is in the remote machine.

Next, if you try to manually ssh to the machine, you will notice that kw failed because of this:

The authenticity of host 'IP (IP)' can't be established.
ED25519 key fingerprint is SHA256:DDDD.
This host key is known by the following other names/addresses:
    ~/.ssh/known_hosts:5: IP
Are you sure you want to continue connecting (yes/no/[fingerprint])?

You just have to say yes, and everything will work fine. This is super annoying and can mislead users; we need to improve how we handle ssh connections inside kw.

We probably need something simple like:

ssh -o "StrictHostKeyChecking no" user@host

Type:

Others

Why:

  • We don't want to mislead users
@rodrigosiqueira rodrigosiqueira added enhancement New feature or request good first issue Good for newcomers deploy labels May 23, 2022
@rodrigosiqueira rodrigosiqueira added this to the kworkflow-beta milestone May 23, 2022
hilookas added a commit to hilookas/kworkflow that referenced this issue Sep 12, 2022
After this commit, ssh will accept new key from remote and save the key
to `known_hosts`.

Ref: https://unix.stackexchange.com/questions/33271/how-to-avoid-ssh-asking-permission

Closes kworkflow#610

Signed-off-by: Haiqin Cui <i@18kas.com>
hilookas added a commit to hilookas/kworkflow that referenced this issue Sep 12, 2022
After this commit, ssh will accept new key from remote and save the key
to `known_hosts`.

Ref: https://unix.stackexchange.com/questions/33271/how-to-avoid-ssh-asking-permission

Closes kworkflow#610

Signed-off-by: Haiqin Cui <i@18kas.com>
@rodrigosiqueira rodrigosiqueira added the done: wait for stable This issue was done, but we are waiting to push it for the master branch. label Sep 30, 2022
Kamorst pushed a commit to Kamorst/kworkflow that referenced this issue Oct 4, 2022
After this commit, ssh will accept new key from remote and save the key
to `known_hosts`.

Ref: https://unix.stackexchange.com/questions/33271/how-to-avoid-ssh-asking-permission

Closes kworkflow#610

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Haiqin Cui <i@18kas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy done: wait for stable This issue was done, but we are waiting to push it for the master branch. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant