Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pokemon HGSS rock smash legality #1379

Closed
NinFanBoyFTW opened this issue Aug 2, 2017 · 7 comments
Closed

pokemon HGSS rock smash legality #1379

NinFanBoyFTW opened this issue Aug 2, 2017 · 7 comments

Comments

@NinFanBoyFTW
Copy link

Hi. I just wanted to let you know that on a few pokemon that I have caught (shuckle, Dunsparce) when I check their legality it says encounter type does not match encounter. For the dunsparce I went into dark cave used rock smash once and a dunsparce appeared. for its encounter it says cave/hall of origin.

@NinFanBoyFTW
Copy link
Author

Also just to let you know I just caught another dunsparce and it is saying the same exact thing

@architdate
Copy link
Contributor

Is this from rock smash too? if so can you send the pk7? @NinFanBoyFTW

@javierhimura
Copy link
Contributor

I think encounter type for rock smash encounters should be checked for every possible location with rocks, just like it has been done with headbutt encounters.

I think the encounter type for rock smash is the same as headbutt trees, it depends on the tile the player is standing, that means in a cave location with a rock it will be cave, a rock inside a city will be building, a rock adyacent to a water tile with have one of the previous plus surfing. What i dont know is where is possible to have the encounter type rock smash itself, maybe in routes? headbutt trees in routes have none encounter.

@architdate
Copy link
Contributor

So a byte resource is whats needed for rock smash encounters i assume? Since the exact locations of those are not yet documented?

@kwsch
Copy link
Owner

kwsch commented Aug 15, 2017

No, all encounters are there. Some maps just have multiple encounter types possible(?) depending on the tile the player is standing on.

@architdate
Copy link
Contributor

Oh I thought since headbutt needed added byte resources, so would rock smash.

@javierhimura
Copy link
Contributor

The headbutt byte resources is only for pokemon crystal. In that game the table encounter used by a tree depend on the coordinates of the tree and the trainer ID, that is why a byte resources is needed, for the coordinates.

For HG and SS instead the headbutt encounters use a table of locations, one table with locations with headbutt in caves, another with headbutt in cities, another with headbutt near water and heabutt near grass. One location can be in more than one table for the headbutt (a route with a tree near grass, another tree near non combat tile and another tree near water for example)

kwsch added a commit that referenced this issue Oct 28, 2017
#1379
need to double check none permissive later
@kwsch kwsch closed this as completed in da9e316 Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants