Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put PKHeX.Core on NuGet #2158

Closed
leo60228 opened this issue Nov 8, 2018 · 6 comments
Closed

Put PKHeX.Core on NuGet #2158

leo60228 opened this issue Nov 8, 2018 · 6 comments
Assignees

Comments

@leo60228
Copy link

leo60228 commented Nov 8, 2018

This would make it easy to include in applications. Assuming the API is unstable (which I'm not sure it is), it would also easily allow pinning to a specific API version via Semver. This especially makes sense now that it's tested on .NET Core, which I don't believe PKHeX uses.

@kwsch
Copy link
Owner

kwsch commented Nov 8, 2018

Might be something for the teamcity server to automatically handle with its automated builds.
Maybe can reduce the amount of updates by only checking when the version.txt is updated...

@evandixon
Copy link
Collaborator

@kwsch

How would you feel about me replacing version.txt with tags, using GitVersion mainline mode?

@kwsch
Copy link
Owner

kwsch commented Nov 8, 2018

The winforms exe uses version.txt to:

  • Display the release date in the program title
  • Compares to github address to check for updates.

If there's an alternative for both of those that doesn't introduce dependencies, then I'm okay with adjusting things. I can always slap a tag on the commit on github

Only reason I brought up version.txt is a possible metric for detecting major releases (and incrementing the package ver)

@evandixon
Copy link
Collaborator

While I work on finding a solution, PKHeX can be found on this MyGet feed:
https://www.myget.org/F/projectpokemon/api/v3/index.json

The version numbers don't really mean anything beyond what TC build it's from. I'll work on fixing that soonish.

@leo60228
Copy link
Author

leo60228 commented Nov 8, 2018 via email

@kwsch
Copy link
Owner

kwsch commented Feb 9, 2019

@kwsch kwsch closed this as completed Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants