Various legality issues (Vivillon/Meowstic)

[NinFanBoyFTW]

Hey I just looked at all of my save files and I noticed a lot of pokemon were illegal for multiple reasons. I have included an example of all the issues I found. All of these issues affect all generations above PK files (example Vespiquin PK4 File but this issue effects gen 4-7). Thanks again

Pokemon.zip

[kwsch]

Nidoking is hacked; it doesn't have any PP Ups so it has to have 10, not 16.

Vivillon(family) & Meowstic are form-related evolution issues, haven't tracked down why things are still misbehaving for those yet :)

[NinFanBoyFTW]

Hey. I didnt hack any of these pokemon and this is happening with more than 2 dozen pokemon that I have. It seems to be an issue with PKHeX transfering the pokemon from Gen 1-2 if that is the problem. The most illegitimate part of any of my pokemon would only be the fact that I imported them with PKHeX directly from the save.

Edit: Also all of these pokemon have been coming up as legit in PKHeX for over a year or 2 so i'm not sure if that means anything about some new legality checks recently

[kwsch]

The PP check is new :)

PKHeX's old transfer code might not have updated the PP counts on transfer; it's now flagging stuff that was probably transferred incorrectly. Viewing and re-saving will fix the issue.

[NinFanBoyFTW]

Hey I tried viewing and re-saving the pokemon and this does not fix the problem. the only way I found to automatically fix this was to change the number of PP ups to a number and then put it back to 0 which makes the PP the normal number. I also noticed that the PP number is an editable text box which imo can lead to many legality issues. I was wondering if it would be possible for you to do 2 things.

1. Make the PP number box a read only box so that it is not editable (and make it writable only for PKHaX mode).

2. Make it so that when you view a pokemon, it makes the PP number automatically go to the legal number (again, unless you are in PKHaX mode).

Thanks again, and hope these changes would be ok to implement.

[ghost]

1. Make the PP number box a read only box so that it is not editable (and make it writable only for PKHaX mode).

I don't think this should be done, since someone may want to manually edit the PP to a specific number, and it allows them to manually heal it.

Also, to heal the move you can just re-select it. But perhaps it can be made so pressing the PP label heals every moves PP?

[asterysx]

About the Meowstic and Vivillon legality issues, I don't know if this is of any help, but I noticed that the only Vivillons that are recognised as legal in my save are the Icy Snow pattern ones, and these show up simply as "Vivillon" when hovering over their sprite, instead of "Vivillon-Icy-Snow" like all the other patterns.

The same seems to be the case with Meowstic: the males show up as "Meowstic" and are seen as legal, whereas the females show up as "Meowstic-F" when hovering and they are seen as invalid.

I attached a few screenshots to illustrate.