-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild package homepage #12
Comments
Thanks for you comments. I have not used GitHub Actions, so I may need help with setting it up, so a pull request would be nice. ZScaler security software is now blocking "realfavicongenerator.net" and so I can no longer build locally on my laptop. :-( |
Except, now that I think about it, there's probably 20+ examples that use |
Ah yes, I use
What do you mean by a flag you can check? Something that will provide a I'll work on a PR for building the pkgdown site via GHA and then we can see what needs fixing up in terms of examples that won't run etc. Alternatively, I can just run the pkgdown build on my machine and submit a PR for that if that's easier? |
I think a better check that is not specific to GitHub is this:
This should enable anyone to download the package repo and check it with
|
Sounds like a sensible approach to me. I'll work on a PR to that effect for you to review. |
I'm working on the changes to asreml. You can work on GitHub Actions.
…On Wed, Jan 31, 2024 at 4:44 PM Sam Rogers ***@***.***> wrote:
Sounds like a sensible approach to me. I'll work on a PR to that effect
for you to review.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADWHJBLK4UMBDMWPRU377DYRLCLBAVCNFSM6AAAAABCQIQUASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQGEYTCMRUGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
Kevin Wright
|
Sorry, just to update, I have had some trouble getting GitHub Actions to build the site properly. Working fine locally, but not on GHA. Still trying to work out why that is. Will try and get it sorted this week. |
Thank you! |
Hi Kevin, thank you very much for your work on this package! I often use or recommend the examples provided in the package.
The package homepage seems to be outdated, which is leading to the "data sources" vignette not being rendered properly. See screenshot attached:
I've just checked the latest version, and it seems to be working fine, so you've obviously fixed the issue in the meantime, but the homepage is still on version 1.19 rather than 1.22.
I can submit a pull request for auto-building the pkgdown site via GitHub actions if that's helpful?
Thanks,
Sam
The text was updated successfully, but these errors were encountered: