Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fastboot) fastboot compat and popper bump to 1.10.2 #16

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

kybishop
Copy link
Owner

Resolves #14

  • Bumps popper dep to v1.10.2
  • Fastboot support
  • Fixes the broken test

@scottwernervt could you confirm that this fixes things for you? A huge thanks for filing an issue and submitting the initial PR!

@kybishop kybishop force-pushed the fastboot-compat-and-bump-popper-version branch from 7cb864a to 5b67bb8 Compare June 19, 2017 21:18
@scottwernervt
Copy link

No errors when serving the app under fastboot and running tests. I completely missed the package fastboot-transform which makes excluding popper.js so much easier than the code in my pull request.

@kybishop kybishop merged commit 87585c1 into master Jun 22, 2017
@kybishop kybishop deleted the fastboot-compat-and-bump-popper-version branch June 22, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastBoot support: ReferenceError: navigator is not defined
2 participants