Skip to content

Commit

Permalink
Merge pull request #16 from kybishop/fastboot-compat-and-bump-popper-…
Browse files Browse the repository at this point in the history
…version

feat(fastboot) fastboot compat and popper bump to 1.10.2
  • Loading branch information
kybishop committed Jun 22, 2017
2 parents a957a62 + 5b67bb8 commit 87585c1
Show file tree
Hide file tree
Showing 6 changed files with 127 additions and 32 deletions.
2 changes: 1 addition & 1 deletion addon/components/ember-popper.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default Ember.Component.extend({

// The popper element needs to be moved higher in the DOM tree to avoid z-index issues.
// See the block-comment in the template for more details.
popperContainer: document.body,
popperContainer: self.document ? self.document.body : '',

// If `true`, the popper element will not be moved to popperContainer. WARNING: This can cause
// z-index issues where your popper will be overlapped by DOM elements that aren't nested as
Expand Down
12 changes: 9 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
/* eslint-env node */
'use strict';

const StripClassCallCheck = require('babel6-plugin-strip-class-callcheck');
const FilterImports = require('babel-plugin-filter-imports');
const RemoveImports = require('./lib/babel-plugin-remove-imports');
const Funnel = require('broccoli-funnel');
const RemoveImports = require('./lib/babel-plugin-remove-imports');
const StripClassCallCheck = require('babel6-plugin-strip-class-callcheck');
const fastbootTransform = require('fastboot-transform');

module.exports = {
name: 'ember-popper',
Expand All @@ -13,7 +14,12 @@ module.exports = {
nodeAssets: {
'popper.js': {
srcDir: 'dist/umd',
import: ['popper.js'],
import: {
include: ['popper.js'],
processTree(input) {
return fastbootTransform(input);
},
},
vendor: ['popper.js.map']
}
}
Expand Down
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,16 @@
"ember-cli-babel": "^6.1.0",
"ember-cli-htmlbars": "^1.3.3",
"ember-cli-node-assets": "^0.2.2",
"popper.js": "^1.9.8"
"fastboot-transform": "^0.1.0",
"popper.js": "^1.10.2"
},
"devDependencies": {
"broccoli-asset-rev": "^2.4.5",
"ember-ajax": "^3.0.0",
"ember-cli": "2.13.2",
"ember-cli-dependency-checker": "^1.3.0",
"ember-cli-eslint": "^3.0.0",
"ember-cli-fastboot": "^1.0.0-rc.4",
"ember-cli-htmlbars-inline-precompile": "^0.4.0",
"ember-cli-inject-live-reload": "^1.4.1",
"ember-cli-qunit": "^4.0.0",
Expand Down
2 changes: 0 additions & 2 deletions tests/dummy/app/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ import config from './config/environment';

let App;

Ember.MODEL_FACTORY_INJECTIONS = true;

App = Ember.Application.extend({
modulePrefix: config.modulePrefix,
podModulePrefix: config.podModulePrefix,
Expand Down
20 changes: 7 additions & 13 deletions tests/integration/components/ember-popper-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,14 @@ moduleForComponent('ember-popper', 'Integration | Component | ember popper', {
});

test('it renders', function(assert) {

// Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });

this.render(hbs`{{ember-popper}}`);

assert.equal(this.$().text().trim(), '');

// Template block usage:
this.render(hbs`
{{#ember-popper}}
template block text
{{/ember-popper}}
<div>
{{#ember-popper popperClass="hello"}}
template block text
{{/ember-popper}}
</div>
`);

assert.equal(this.$().text().trim(), 'template block text');
let popper = document.querySelector('.hello');
assert.equal(popper.innerHTML.trim(), 'template block text');
});
119 changes: 107 additions & 12 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ broccoli-funnel-reducer@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/broccoli-funnel-reducer/-/broccoli-funnel-reducer-1.0.0.tgz#11365b2a785aec9b17972a36df87eef24c5cc0ea"

broccoli-funnel@^1.0.0, broccoli-funnel@^1.0.1, broccoli-funnel@^1.0.6, broccoli-funnel@^1.0.7, broccoli-funnel@^1.1.0:
broccoli-funnel@^1.0.0, broccoli-funnel@^1.0.1, broccoli-funnel@^1.0.6, broccoli-funnel@^1.0.7, broccoli-funnel@^1.1.0, broccoli-funnel@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/broccoli-funnel/-/broccoli-funnel-1.2.0.tgz#cddc3afc5ff1685a8023488fff74ce6fb5a51296"
dependencies:
Expand Down Expand Up @@ -1304,7 +1304,7 @@ broccoli-sri-hash@^2.1.0:
sri-toolbox "^0.2.0"
symlink-or-copy "^1.0.1"

broccoli-stew@^1.2.0, broccoli-stew@^1.3.3:
broccoli-stew@^1.2.0, broccoli-stew@^1.3.3, broccoli-stew@^1.5.0:
version "1.5.0"
resolved "https://registry.yarnpkg.com/broccoli-stew/-/broccoli-stew-1.5.0.tgz#d7af8c18511dce510e49d308a62e5977f461883c"
dependencies:
Expand Down Expand Up @@ -1603,7 +1603,7 @@ compressible@~2.0.8:
dependencies:
mime-db ">= 1.27.0 < 2"

compression@^1.4.4:
compression@^1.4.4, compression@^1.6.2:
version "1.6.2"
resolved "https://registry.yarnpkg.com/compression/-/compression-1.6.2.tgz#cceb121ecc9d09c52d7ad0c3350ea93ddd402bc3"
dependencies:
Expand Down Expand Up @@ -1680,6 +1680,10 @@ cookie@0.3.1:
version "0.3.1"
resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.3.1.tgz#e7e0a1f9ef43b4c8ba925c5c5a96e806d16873bb"

cookie@^0.2.3:
version "0.2.4"
resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.2.4.tgz#a8c155aa7b9b2cf2c4d32ebc7b9a0aa288ccc6bd"

copy-dereference@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/copy-dereference/-/copy-dereference-1.0.0.tgz#6b131865420fd81b413ba994b44d3655311152b6"
Expand All @@ -1696,6 +1700,12 @@ core-object@^1.1.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/core-object/-/core-object-1.1.0.tgz#86d63918733cf9da1a5aae729e62c0a88e66ad0a"

core-object@^2.0.5:
version "2.1.1"
resolved "https://registry.yarnpkg.com/core-object/-/core-object-2.1.1.tgz#4b7a5f1edefcb1e6d0dcb58eab1b9f90bfc666a8"
dependencies:
chalk "^1.1.3"

core-object@^3.0.0:
version "3.1.0"
resolved "https://registry.yarnpkg.com/core-object/-/core-object-3.1.0.tgz#f5219fec2a19c40956f1c723d121890c88c5f677"
Expand Down Expand Up @@ -1893,7 +1903,7 @@ ember-ajax@^3.0.0:
dependencies:
ember-cli-babel "^6.0.0"

ember-cli-babel@^5.1.5:
ember-cli-babel@^5.1.5, ember-cli-babel@^5.1.7:
version "5.2.4"
resolved "https://registry.yarnpkg.com/ember-cli-babel/-/ember-cli-babel-5.2.4.tgz#5ce4f46b08ed6f6d21e878619fb689719d6e8e13"
dependencies:
Expand Down Expand Up @@ -1945,6 +1955,32 @@ ember-cli-eslint@^3.0.0:
rsvp "^3.2.1"
walk-sync "^0.3.0"

ember-cli-fastboot@^1.0.0-rc.4:
version "1.0.0-rc.4"
resolved "https://registry.yarnpkg.com/ember-cli-fastboot/-/ember-cli-fastboot-1.0.0-rc.4.tgz#e94461f90b51ef991f6db5246bd55222d17d1658"
dependencies:
broccoli-concat "^3.2.2"
broccoli-funnel "^1.2.0"
broccoli-merge-trees "^1.1.1"
broccoli-plugin "^1.2.1"
broccoli-stew "^1.2.0"
chalk "^1.1.3"
compression "^1.6.2"
core-object "^2.0.5"
debug "^2.2.0"
ember-cli-babel "^5.1.7"
ember-cli-version-checker "^1.3.1"
exists-sync "0.0.4"
express "^4.8.5"
fastboot "1.0.0-rc.6"
fastboot-express-middleware "1.0.0-rc.7"
json-stable-stringify "^1.0.1"
lodash.defaults "^4.0.1"
lodash.uniq "^4.2.0"
md5-hex "^1.3.0"
rsvp "^3.0.16"
silent-error "^1.0.0"

ember-cli-get-component-path-option@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/ember-cli-get-component-path-option/-/ember-cli-get-component-path-option-1.0.0.tgz#0d7b595559e2f9050abed804f1d8eff1b08bc771"
Expand Down Expand Up @@ -2595,7 +2631,11 @@ expand-tilde@^1.2.2:
dependencies:
os-homedir "^1.0.1"

express@^4.10.7, express@^4.12.3:
express-cluster@0.0.4:
version "0.0.4"
resolved "https://registry.yarnpkg.com/express-cluster/-/express-cluster-0.0.4.tgz#7aa5c39779bbc7550a30525d02b4c022e40b8798"

express@^4.10.7, express@^4.12.3, express@^4.13.3, express@^4.8.5:
version "4.15.3"
resolved "https://registry.yarnpkg.com/express/-/express-4.15.3.tgz#bab65d0f03aa80c358408972fc700f916944b662"
dependencies:
Expand Down Expand Up @@ -2673,6 +2713,36 @@ fast-sourcemap-concat@^1.0.1:
source-map "^0.4.2"
source-map-url "^0.3.0"

fastboot-express-middleware@1.0.0-rc.7:
version "1.0.0-rc.7"
resolved "https://registry.yarnpkg.com/fastboot-express-middleware/-/fastboot-express-middleware-1.0.0-rc.7.tgz#285dee01734d40bafe983cefb63e7df0c680f282"
dependencies:
chalk "^1.1.3"
fastboot "^1.0.0-rc.3"

fastboot-transform@^0.1.0:
version "0.1.0"
resolved "https://registry.yarnpkg.com/fastboot-transform/-/fastboot-transform-0.1.0.tgz#c00c3c4f376b4e788278cec5cb8d35488e083c07"
dependencies:
broccoli-stew "^1.5.0"

fastboot@1.0.0-rc.6, fastboot@^1.0.0-rc.3:
version "1.0.0-rc.6"
resolved "https://registry.yarnpkg.com/fastboot/-/fastboot-1.0.0-rc.6.tgz#09af88b41d1b31fda96be425c857e34b2323115b"
dependencies:
chalk "^0.5.1"
cookie "^0.2.3"
debug "^2.1.0"
exists-sync "0.0.3"
express "^4.13.3"
express-cluster "0.0.4"
glob "^4.0.5"
minimist "^1.2.0"
najax "^1.0.1"
rsvp "^3.0.16"
simple-dom "^0.3.0"
source-map-support "^0.4.0"

faye-websocket@~0.10.0:
version "0.10.0"
resolved "https://registry.yarnpkg.com/faye-websocket/-/faye-websocket-0.10.0.tgz#4e492f8d04dfb6f89003507f6edbf2d501e7c6f4"
Expand Down Expand Up @@ -2955,6 +3025,15 @@ glob@7.1.1, glob@^7.0.0, glob@^7.0.3, glob@^7.0.4, glob@^7.0.5:
once "^1.3.0"
path-is-absolute "^1.0.0"

glob@^4.0.5:
version "4.5.3"
resolved "https://registry.yarnpkg.com/glob/-/glob-4.5.3.tgz#c6cb73d3226c1efef04de3c56d012f03377ee15f"
dependencies:
inflight "^1.0.4"
inherits "2"
minimatch "^2.0.1"
once "^1.3.0"

glob@^5.0.10, glob@^5.0.15:
version "5.0.15"
resolved "https://registry.yarnpkg.com/glob/-/glob-5.0.15.tgz#1bc936b9e02f4a603fcc222ecf7633d30b8b93b1"
Expand Down Expand Up @@ -3438,6 +3517,10 @@ jodid25519@^1.0.0:
dependencies:
jsbn "~0.1.0"

jquery-deferred@^0.3.0:
version "0.3.1"
resolved "https://registry.yarnpkg.com/jquery-deferred/-/jquery-deferred-0.3.1.tgz#596eca1caaff54f61b110962b23cafea74c35355"

jquery@^3.1.1:
version "3.2.1"
resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.2.1.tgz#5c4d9de652af6cd0a770154a631bba12b015c787"
Expand Down Expand Up @@ -3670,6 +3753,10 @@ lodash.debounce@^3.1.1:
dependencies:
lodash._getnative "^3.0.0"

lodash.defaults@^4.0.1:
version "4.2.0"
resolved "https://registry.yarnpkg.com/lodash.defaults/-/lodash.defaults-4.2.0.tgz#d09178716ffea4dde9e5fb7b37f6f0802274580c"

lodash.defaultsdeep@^4.6.0:
version "4.6.0"
resolved "https://registry.yarnpkg.com/lodash.defaultsdeep/-/lodash.defaultsdeep-4.6.0.tgz#bec1024f85b1bd96cbea405b23c14ad6443a6f81"
Expand Down Expand Up @@ -3849,7 +3936,7 @@ matcher-collection@^1.0.0, matcher-collection@^1.0.1:
dependencies:
minimatch "^3.0.2"

md5-hex@^1.0.2:
md5-hex@^1.0.2, md5-hex@^1.3.0:
version "1.3.0"
resolved "https://registry.yarnpkg.com/md5-hex/-/md5-hex-1.3.0.tgz#d2c4afe983c4370662179b8cad145219135046c4"
dependencies:
Expand Down Expand Up @@ -3944,7 +4031,7 @@ mime@^1.2.11:
dependencies:
brace-expansion "^1.1.7"

minimatch@^2.0.3:
minimatch@^2.0.1, minimatch@^2.0.3:
version "2.0.10"
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-2.0.10.tgz#8d087c39c6b38c001b97fca7ce6d0e1e80afbac7"
dependencies:
Expand Down Expand Up @@ -4006,6 +4093,14 @@ mute-stream@0.0.6:
version "0.0.6"
resolved "https://registry.yarnpkg.com/mute-stream/-/mute-stream-0.0.6.tgz#48962b19e169fd1dfc240b3f1e7317627bbc47db"

najax@^1.0.1:
version "1.0.3"
resolved "https://registry.yarnpkg.com/najax/-/najax-1.0.3.tgz#11145f4d910446ea661d8ab7fcef53f6ad164ae5"
dependencies:
jquery-deferred "^0.3.0"
lodash.defaultsdeep "^4.6.0"
qs "^6.2.0"

nan@^2.3.0:
version "2.6.2"
resolved "https://registry.yarnpkg.com/nan/-/nan-2.6.2.tgz#e4ff34e6c95fdfb5aecc08de6596f43605a7db45"
Expand Down Expand Up @@ -4311,9 +4406,9 @@ pluralize@^1.2.1:
version "1.2.1"
resolved "https://registry.yarnpkg.com/pluralize/-/pluralize-1.2.1.tgz#d1a21483fd22bb41e58a12fa3421823140897c45"

popper.js@^1.9.8:
version "1.9.8"
resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.9.8.tgz#551c16b8ca853d479dd3a1ee48c7caec43687cbb"
popper.js@^1.10.2:
version "1.10.2"
resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.10.2.tgz#3d2d7788e1d85286051633dac6d23554134e4a04"

portfinder@^1.0.7:
version "1.0.13"
Expand Down Expand Up @@ -4378,7 +4473,7 @@ q@^1.1.2:
version "1.5.0"
resolved "https://registry.yarnpkg.com/q/-/q-1.5.0.tgz#dd01bac9d06d30e6f219aecb8253ee9ebdc308f1"

qs@6.4.0, qs@^6.4.0, qs@~6.4.0:
qs@6.4.0, qs@^6.2.0, qs@^6.4.0, qs@~6.4.0:
version "6.4.0"
resolved "https://registry.yarnpkg.com/qs/-/qs-6.4.0.tgz#13e26d28ad6b0ffaa91312cd3bf708ed351e7233"

Expand Down Expand Up @@ -4891,7 +4986,7 @@ source-map-support@^0.2.10:
dependencies:
source-map "0.1.32"

source-map-support@^0.4.2:
source-map-support@^0.4.0, source-map-support@^0.4.2:
version "0.4.15"
resolved "https://registry.yarnpkg.com/source-map-support/-/source-map-support-0.4.15.tgz#03202df65c06d2bd8c7ec2362a193056fef8d3b1"
dependencies:
Expand Down

0 comments on commit 87585c1

Please sign in to comment.