Remove decorators

[mhluska]

I was having some issues in my app related to decorators. I realized this is the only dependency in my tree relying on them. I started to think that it's somewhat strange to require them in a library that others might use as a building block.

This also removes yarn, removes some unneeded dependencies and fixes an npm vulnerability (npm audit fix --force).

I realize this is a pretty controversial PR and should probably be split up into smaller chunks. I can do it if needed.

I made sure tests are passing locally and I'm using this in production.

[artzte]

+1 on merging this if possible. This patch unblocked us. Thanks @mhluska

[pzuraq]

The referenced issue was actually related to a build time bug, which affected multiple projects in the Ember ecosystem and has been patched. You should be able to fix the issue by running yarn update or the equivalent to update your lockfiles.

Decorators have been stable for some time, and native class syntax is the future direction for Ember as a whole. ember-popper was admittedly an early adopter here, but we gained valuable insight from the project and it helped us pave that path forward 😄 that said, if @kybishop would like to transition back to EmberObject until native classes become the standard, I don't have any issues with that myself. I would recommend against removing Yarn, however, since it is still much faster for CI runs than NPM in my own experience.

[artzte]

We are using NPM on our project. I am not seeing an update in our package-lock.json when clean-reinstalling our project dependencies, even after clearing my local cache. What do you think we are missing?

[pzuraq]

I'm not too sure as I don't have much experience with NPM lockfiles. You should be able to check to see if the build dependency has updated though. The affected version was ember-compatibility-helpers@v1.1.0, and the fixed versions are ember-compatibility-helpers@v1.1.1 and ember-compatibility-helpers@v1.1.2. If you're still seeing the issue with either of those package versions, we should reopen an issue on ember-compatibility-helpers.

[mhluska]

@pzuraq I'm totally fine with keeping yarn. I've reverted those changes.

[kybishop]

Sorry for the delay life has been absurdly busy lately.

I'm generally 👍 on this change. Exploring decorators has been interesting, but feels like it has caused more issues than it has solved. In the long-term, I'm much more interested in using Typescript over decorators.

I want to give this a slightly more thorough lookover in the next few days before merging.