Asynchronous sendStatus(), pass WAL position to handler, fix plugin args etc #2
Conversation
blind-oracle
changed the title
|
@kyleconroy @blind-oracle great collaboration! any chance we can get this merged upstream? Thank you for your hard work! |
|
@jmealo sure! I honestly had forgotten about this pull request 😬 @blind-oracle do you have time to make some changes? I know this code is from a while back. |
examples/replicate.go
Outdated
| @@ -5,8 +5,8 @@ import ( | |||
| "fmt" | |||
| "log" | |||
|
|
|||
| "github.com/blind-oracle/pgoutput" | |||
There was a problem hiding this comment.
I know this is useful for testing, but this needs to be reverted before merging.
examples/replicate.go
Outdated
| @@ -50,8 +49,8 @@ func main() { | |||
| return nil | |||
| } | |||
|
|
|||
| sub := pgoutput.NewSubscription("sub1", "pub1") | |||
| if err := sub.Start(ctx, conn, handler); err != nil { | |||
| sub := pgoutput.NewSubscription(conn, "sub1", "pub1", 1048576) | |||
There was a problem hiding this comment.
I know this is just an example, but can we reset the offset value here to zero?
|
Sorry, I also forgot about it and kept committing our project-specific stuff to my fork that ended up here :) Regarding vendor folder - I had conflicts between different version of libraries (pgoutput's vs our project's) if I remember correctly. Some points against committing vendor to repo also here https://github.com/golang/dep/blob/master/docs/FAQ.md#my-dependers-dont-use-dep-yet-what-should-i-do And if you take a look at most other popular libraries - they don't commit vendor folder to repo. Maybe we should just use dep's Gopkg.toml/.lock instead if we need to pin specific versions. |
|
Makes sense about the vendor directory, as this is a library. Instead of committing a Gopkg.* file, I think I'll just tag a |
|
Ok I've done some modifications & fixes, it should be Ok now. But since the API was changed probably we want to retain current version under some tag. |
|
Thanks for looking into this! |
|
Any chance this would be merged? |
Thanks for a very good work on pgoutput.
Some changes that I did for our project that may be useful to somebody and maybe worth integrating to the base project.