Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Swift 4.2 #56

Merged
merged 3 commits into from
Sep 10, 2018
Merged

Update for Swift 4.2 #56

merged 3 commits into from
Sep 10, 2018

Conversation

keith
Copy link
Collaborator

@keith keith commented Sep 10, 2018

This likely shouldn't be merged until Swift 4.2 is officially released
(hopefully this week)

@keith
Copy link
Collaborator Author

keith commented Sep 10, 2018

It wouldn't hurt to get this update with this change kylef/Spectre#37

@keith
Copy link
Collaborator Author

keith commented Sep 10, 2018

CI is failing until Swift 4.2 is released

@keith
Copy link
Collaborator Author

keith commented Sep 10, 2018

this fails because Swift 4.2 isn't installable on Linux with swiftenv yet. If we want I can remove that new build in the matrix for now, since we are covered by the Xcode 10 build, and we can add it after the public release, or we can hold on merging this until then.

@kylef kylef merged commit 745db72 into master Sep 10, 2018
@kylef kylef deleted the ks/swift-4.2 branch September 10, 2018 18:16
@lndobryden lndobryden mentioned this pull request Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants