Adds extraclasses option to events; #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace element instead of putting stuff inside it. (keep extraClasses) Correct bug when lengthOfTime is not a month;
mikegioia
reviewed
Oct 3, 2016
| } | ||
|
|
||
| } | ||
| } ) |
There was a problem hiding this comment.
This looks pretty verbose for what I think is just a space delineated concatenation of the classes.
What if it was just:
extraClasses += (" " + this.options.classes.event)
+ (_.isArray(event.extraClasses) ? " " + event.extraClasses.join(" ") : "");
?
There was a problem hiding this comment.
I tried to preserve initial codestyle.
|
Thanks @long-lazuli I'm going to get to these today. Also (FYI) you don't have to update the version, that all happens during a compilation step in master. This one was the only open PR but if we had 2 or more that all incremented the version they'd eventually conflict :P I can reset it during the merge. |
|
Thx for this explanation about versions, @mikegioia |
mikegioia
added a commit
that referenced
this pull request
May 28, 2019
mikegioia
added a commit
that referenced
this pull request
May 28, 2019
* Fixes audit warnings and errors with new packages; adding package lock file * Audited NPM packages and linted src file. All lint errors and warnings have been fixed. * Resolves #332 * Merged fix for #330 and added tests that verify it * Fixes bug found from a fix in #281 * Recompiled assets and updated changelog for 1.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace element instead of putting stuff inside it. (keep extraClasses)
Correct bug when lengthOfTime is not a month;