Add support for mapper 2 (UxROM) #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Sorry I've been slow to review it (had surgery recently), but I did take a quick look not too long ago and code-wise it looks good. I'll test it out myself sometime soon and merge it if it's all working well (honestly, I don't really have the expertise to tell if all the different mappers work as expected, so I take a pretty loose approach on merging new mappers in general... I figure if it helps one person it'll help others, and folks can report bugs if things aren't working) |
kylewlacy
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, 100% ChatGPT. I'm starting my adventure on NES disassembly right now with Mega Man and GhidraNes seemed like a great tool.
It compiled and worked on Ghidra, but I wouldn't be able to say if mapping is really correct or not
EDIT: tested with Ghidra 10.3.3