Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

AWS and Azure broker docu-checker resource naming fixes (kyma#5185) #112

Merged
merged 1 commit into from
Aug 23, 2019
Merged

AWS and Azure broker docu-checker resource naming fixes (kyma#5185) #112

merged 1 commit into from
Aug 23, 2019

Conversation

m-wcislo
Copy link
Contributor

@m-wcislo m-wcislo commented Aug 19, 2019

Description

Changes proposed in this pull request:

  • limit resource names created in aws and azure brokers charts to max 63 chars. Docu-checker templates/resources were possibly violating 63 chars constraints.

Related issue(s)
Fixes kyma-project/kyma#5185

Tested/verified only with Azure.

@kyma-bot
Copy link
Collaborator

Hi @m-wcislo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2019

CLA assistant check
All committers have signed the CLA.

@mszostok
Copy link
Contributor

/ok-to-test

@mszostok
Copy link
Contributor

/test all

Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @m-wcislo, thanks for your contribution!

At the beginning, I thought about doing that by new def in _helpers.tpl file to make it DRY but after a while IMO for now, it's good enough to have it like that, so /lgtm

@mszostok mszostok merged commit a650821 into kyma-project:master Aug 23, 2019
@m-wcislo
Copy link
Contributor Author

m-wcislo commented Aug 23, 2019 via email

@mszostok mszostok added kind/bug Categorizes issue or PR as related to a bug. area/service-management Issues or PRs related to service management labels Aug 24, 2019
@m-wcislo m-wcislo deleted the docu-checker-fix-for-azure-and-aws-broker branch September 15, 2019 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/service-management Issues or PRs related to service management kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cni network plugin not happy with names > 63 chars
4 participants