Infrastructure Manager creates secrets when a new Gardener Cluster CR is created. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
This was referenced Sep 15, 2023
kyma-bot
added
size/XL
|
By mistake this PR was not created to the |
Disper
removed
the
do-not-merge/work-in-progress
Disper
changed the title
akgalwas
changed the title
VOID404
reviewed
Sep 21, 2023
Dockerfile
Outdated
| COPY cmd/main.go cmd/main.go | ||
| COPY api/ api/ | ||
| COPY internal/controller/ internal/controller/ | ||
| COPY . ./ |
There was a problem hiding this comment.
Is everything in this folder really needed? Folders like docs aren't excluded here nor in the .dockerignore
akgalwas
reviewed
Sep 22, 2023
akgalwas
requested changes
Sep 22, 2023
akgalwas
previously approved these changes
Sep 22, 2023
Disper
dismissed
akgalwas’s stale review
The merge-base changed after approval.
akgalwas
previously approved these changes
Sep 22, 2023
Disper
dismissed
akgalwas’s stale review
The merge-base changed after approval.
… into kubeconfig_secret_creation
akgalwas
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
/area control-plane
/kind feature
Related issue(s)
#10