Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure Manager removes secrets when Gardener Cluster CR is deleted #39

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Infrastructure Manager removes secrets when Gardener Cluster CR is deleted #39

merged 5 commits into from
Sep 25, 2023

Conversation

Disper
Copy link
Member

@Disper Disper commented Sep 19, 2023 •
edited by akgalwas
Loading

Description

Please review after #37

Changes proposed in this pull request:

  • Infrastructure Manager removes secrets when Gardener Cluster CR is deleted.
  • ...
  • ...

Related issue(s)
#10

/area control-plane
/kind feature

@Disper Disper requested a review from a team as a code owner September 19, 2023 07:26
@kyma-bot kyma-bot added area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 19, 2023
@Disper Disper mentioned this pull request Sep 19, 2023
Closed
6 tasks
@akgalwas akgalwas changed the title Infrastructure Manager removes secrets when Cluster Inventory CR is deleted. Infrastructure Manager removes secrets when Gardener Cluster CR is deleted. Sep 20, 2023
@Disper Disper changed the title Infrastructure Manager removes secrets when Gardener Cluster CR is deleted. [WiP] Infrastructure Manager removes secrets when Gardener Cluster CR is deleted Sep 21, 2023
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@Disper
Copy link
Member Author

Disper commented Sep 21, 2023

Added back [WiP] as jobs are failing.

@Disper Disper changed the title [WiP] Infrastructure Manager removes secrets when Gardener Cluster CR is deleted Infrastructure Manager removes secrets when Gardener Cluster CR is deleted Sep 21, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@akgalwas akgalwas mentioned this pull request Sep 22, 2023
Merged
akgalwas
akgalwas previously approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@akgalwas akgalwas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Disper Disper dismissed akgalwas’s stale review September 22, 2023 05:06

The merge-base changed after approval.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2023
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 22, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 25, 2023
@kyma-bot kyma-bot merged commit 7cf18b1 into kyma-project:main Sep 25, 2023
5 checks passed
@Disper Disper self-assigned this Sep 26, 2023
@Disper Disper deleted the kubeconfig_secret_removal branch September 27, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akgalwas akgalwas akgalwas approved these changes

Assignees

@Disper Disper

@akgalwas akgalwas

Labels
area/control-plane Related to all activities around Kyma Control Plane kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Disper @akgalwas @kyma-bot