Add more logging when ns deletion fails to work #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venturasr
requested review from
joek,
lilitgh,
rakesh-garimella and
sayanh
as code owners
venturasr
force-pushed
the
add-more-log-to-test-kubeless
branch
2 times, most recently
from
797ac0f
to
1b99beb
Compare
venturasr
force-pushed
the
add-more-log-to-test-kubeless
branch
from
8db9172
to
38fb097
Compare
aszecowka
suggested changes
Oct 11, 2018
| @@ -41,11 +41,17 @@ func deleteNamespace(namespace string) { | |||
| for { | |||
| select { | |||
| case <-timeout: | |||
| cmd := exec.Command("kubectl", "get", "ns", namespace, "-o yaml") | |||
There was a problem hiding this comment.
It will not solve our problem. Printing namespace details tell us only that namespace has "kubernetes" finalizer - but still, we don't know which object from this namespace cannot be removed.
Could you analize "namespaced_resources_deleter.go" (https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/pkg/controller/namespace/deletion/namespaced_resources_deleter.go), especially deleteAllContent method. They are using the dynamic client to detect what should be deleted. Maybe we can do the same and just print resources which are still not deleted after the timeout (6min)
sayanh
force-pushed
the
add-more-log-to-test-kubeless
branch
8 times, most recently
from
0094b4f
to
3185738
Compare
- Added force deletion of all k8s resources - Added extensive logging while deletion of ns times out
sayanh
force-pushed
the
add-more-log-to-test-kubeless
branch
from
3185738
to
c7d4408
Compare
sayanh
changed the title
sayanh
approved these changes
Oct 15, 2018
dekiel
referenced
this pull request
in dekiel/kyma
Jul 16, 2019
dekiel
referenced
this pull request
in dekiel/kyma
Jul 18, 2019
dekiel
referenced
this pull request
in dekiel/kyma
Jul 19, 2019
dekiel
referenced
this pull request
in dekiel/kyma
Jul 23, 2019
grischperl
pushed a commit
to grischperl/kyma
that referenced
this pull request
Nov 10, 2020
* Added pre-master-kyma-gke-integration-xip-dubg job. * Added debug job tests in separate function due to conflicts with other presubmit jobs settings.
grischperl
pushed a commit
to grischperl/kyma
that referenced
this pull request
Nov 10, 2020
* Added pre-master-kyma-gke-integration-xip-dubg job. * Added missing base_ref value for extra_refs. * Moved debug job tests to separate function due to conflicts with other presubmit jobs settings. * Changed branch name. * Changed SkipReport test expected value. * Reverted CLEANUP_CLUSTER value. It will be changed after merge. * Disabled cluster cleanup. * Enabled xip.io DNS for kyma-gke-integration-xip-debug job. * Corrected typo in job template name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request add some logging to test-kubeless, in order to identify a possible reason for the time out when namespaces are being deleted.
Related issue(s)