implement mutex in bebmock subscriptions #12781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friedrichwilken
requested review from
lilitgh,
marcobebway,
mfaizanse,
nachtmaar and
pxsalehi
as code owners
kyma-bot
added
the
size/M
k15r
reviewed
Dec 3, 2021
k15r
previously approved these changes
Dec 3, 2021
kyma-bot
added
size/L
friedrichwilken
force-pushed
the
mockbeb-mutex
branch
3 times, most recently
from
2f1f30e
to
a2458e5
Compare
friedrichwilken
force-pushed
the
mockbeb-mutex
branch
from
a0e842b
to
acff7b4
Compare
k15r
reviewed
Dec 6, 2021
components/eventing-controller/controllers/subscription/beb/reconciler_test.go
Outdated
Show resolved
Hide resolved
k15r
reviewed
Dec 6, 2021
There was a problem hiding this comment.
cant we use https://onsi.github.io/gomega/#containelementelement-interface these matchers in our tests?
|
✔️ 🥰 Documentation preview ready! 🥰 🔨 Explore the source changes: 972a6f4 🔍 Inspect the deploy log: https://app.netlify.com/sites/kyma-project-docs-preview/deploys/61af7ba5c8adfc0008ae4943 😎 Browse the preview: https://deploy-preview-12781--kyma-project-docs-preview.netlify.app |
|
/retest |
k15r
approved these changes
Dec 8, 2021
pxsalehi
pushed a commit
to pxsalehi/kyma
that referenced
this pull request
Jan 11, 2022
* implement mutex in bebmock subscriptions and requests * simplify beb reconciler test * breaking beb * re-fix countBEBRequests * fix imports
pxsalehi
added a commit
that referenced
this pull request
Jan 11, 2022
* eventing controller reconciler should validate only the host part in sink url (#12811) Co-authored-by: johgoe <johannes.goehr@mobilexag.de> * implement mutex in bebmock subscriptions (#12781) * implement mutex in bebmock subscriptions and requests * simplify beb reconciler test * breaking beb * re-fix countBEBRequests * fix imports * Preserve Eventing Publisher proxy deployment annotations after reconciliation (#12769) * Preserve publisher deployment annotations * Update Eventing controller image * Add a unit-test * Preserve allowed annotations only * Increased timeout and separated out nats invalid sink tests (#12826) * increased timeout and separated out nats invalid sink tests * removed replicated code * Update components/eventing-controller/controllers/subscription/nats/reconciler_test.go Co-authored-by: Friedrich <58187735+FriedrichWilken@users.noreply.github.com> Co-authored-by: Friedrich <58187735+FriedrichWilken@users.noreply.github.com> * Fix endless reconciliation of the Publisher proxy deployment (#12833) * Fix endless reconciliation of the Publisher proxy deployment * Update Eventing controller image * Fix "retry sending an event to sink" for NATS dispatcher (#12808) * add retry strategy for NATS dispatcher * solve check-imports * solve vet issues * Add the retry configurable parameters to charts * solve spelling errors * bump eventing-controller image to PR-12808 * solve check-imports * Extend the retrying tests to check the sent/received data too, solve comments * Solve check-imports * Rename URLs to solve comments * Update README.md * Update components/eventing-controller/README.md Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * do not use PR image Co-authored-by: johgoe <johannes.goehr@gmx.net> Co-authored-by: johgoe <johannes.goehr@mobilexag.de> Co-authored-by: Friedrich <58187735+FriedrichWilken@users.noreply.github.com> Co-authored-by: Marco Bebway <marco.bebway@sap.com> Co-authored-by: Muhammad Faizan <mfaizanse@users.noreply.github.com> Co-authored-by: Radu Fantaziu <radu.fantaziu@sap.com> Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding mutex to the subscriptions and requests of beb mock.