eventing controller reconciler should validate only the host part in … #12811
Conversation
johgoe
requested review from
k15r,
lilitgh,
marcobebway,
mfaizanse,
nachtmaar and
pxsalehi
as code owners
|
|
|
Hi @johgoe. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kyma-bot
added
the
size/XS
|
@johgoe: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @johgoe , thanks for the quick fix. May i ask you to add a simple test to your PR to test that behaviour? |
ghost
mentioned this pull request
…sink url (kyma-project#12811) Co-authored-by: johgoe <johannes.goehr@mobilexag.de>
* eventing controller reconciler should validate only the host part in sink url (#12811) Co-authored-by: johgoe <johannes.goehr@mobilexag.de> * implement mutex in bebmock subscriptions (#12781) * implement mutex in bebmock subscriptions and requests * simplify beb reconciler test * breaking beb * re-fix countBEBRequests * fix imports * Preserve Eventing Publisher proxy deployment annotations after reconciliation (#12769) * Preserve publisher deployment annotations * Update Eventing controller image * Add a unit-test * Preserve allowed annotations only * Increased timeout and separated out nats invalid sink tests (#12826) * increased timeout and separated out nats invalid sink tests * removed replicated code * Update components/eventing-controller/controllers/subscription/nats/reconciler_test.go Co-authored-by: Friedrich <58187735+FriedrichWilken@users.noreply.github.com> Co-authored-by: Friedrich <58187735+FriedrichWilken@users.noreply.github.com> * Fix endless reconciliation of the Publisher proxy deployment (#12833) * Fix endless reconciliation of the Publisher proxy deployment * Update Eventing controller image * Fix "retry sending an event to sink" for NATS dispatcher (#12808) * add retry strategy for NATS dispatcher * solve check-imports * solve vet issues * Add the retry configurable parameters to charts * solve spelling errors * bump eventing-controller image to PR-12808 * solve check-imports * Extend the retrying tests to check the sent/received data too, solve comments * Solve check-imports * Rename URLs to solve comments * Update README.md * Update components/eventing-controller/README.md Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com> * do not use PR image Co-authored-by: johgoe <johannes.goehr@gmx.net> Co-authored-by: johgoe <johannes.goehr@mobilexag.de> Co-authored-by: Friedrich <58187735+FriedrichWilken@users.noreply.github.com> Co-authored-by: Marco Bebway <marco.bebway@sap.com> Co-authored-by: Muhammad Faizan <mfaizanse@users.noreply.github.com> Co-authored-by: Radu Fantaziu <radu.fantaziu@sap.com> Co-authored-by: Aleksandra Simeonova <aleksandra.simeonova@sap.com>
eventing controller reconciler should validate only the host part in sink url (#12810)