Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rafter from kyma components #13851

Merged
merged 1 commit into from Jun 20, 2022
Merged

Remove rafter from kyma components #13851

merged 1 commit into from Jun 20, 2022

Conversation

kwiatekus
Copy link
Contributor

@kwiatekus kwiatekus commented Apr 5, 2022 •
edited

Description

Changes proposed in this pull request:

  • do not install rafter and its CRDs
  • remove dedicated rafter roles

Related issue(s)
#13155
Depends on #12844, kyma-project/test-infra#5386

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 5, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/core-and-supporting Issues or PRs related to core and supporting area/installation Issues or PRs related to installation size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 5, 2022
@kwiatekus kwiatekus added area/luigi Related to all activities around Luigi micro-frontend framework and removed area/luigi Related to all activities around Luigi micro-frontend framework labels Apr 6, 2022
@kwiatekus
Copy link
Contributor Author

/meow

@kyma-bot
Copy link
Contributor

kyma-bot commented Apr 6, 2022

@kwiatekus: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pPrecel pPrecel mentioned this pull request Apr 20, 2022
Closed
@pPrecel
Copy link
Contributor

pPrecel commented Apr 20, 2022

/test all

1 similar comment
@pPrecel
Copy link
Contributor

pPrecel commented Apr 20, 2022

/test all

@pPrecel
Copy link
Contributor

pPrecel commented Apr 21, 2022

/retest

@kyma-bot kyma-bot added do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. area/charts Issues or PRs related to changes in charts area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh area/tests Issues or PRs related to tests size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 25, 2022
@kwiatekus kwiatekus changed the title SPIKE: Do not install rafter Remove rafter from kyma components Apr 25, 2022
@pPrecel
Copy link
Contributor

pPrecel commented Apr 25, 2022

/test all

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/missing-docs-review Indicates that a PR should not merge beacuse it has missing documentation review. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2022
@kyma-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from kwiatekus after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwiatekus kwiatekus mentioned this pull request Apr 26, 2022
Closed
6 tasks
@pPrecel
Copy link
Contributor

pPrecel commented Apr 26, 2022

/test all

@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2022
@kwiatekus kwiatekus added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2022
@moelsayed
Copy link
Contributor

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Jun 20, 2022 •
edited

@kwiatekus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kyma-tests-rafter 877531f link true /test pre-kyma-tests-rafter
pre-main-kyma-integration-k3d-central-app-connectivity e1ab8be link true /test pre-main-kyma-integration-k3d-central-app-connectivity
pre-main-kyma-integration-k3d-istio-production e1ab8be link true /test pre-main-kyma-integration-k3d-istio-production
pre-kyma-tests-components-application-connector e1ab8be link true /test pre-kyma-tests-components-application-connector
pre-main-kyma-integration-k3d-istio-evaluation e1ab8be link true /test pre-main-kyma-integration-k3d-istio-evaluation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

moelsayed
moelsayed previously approved these changes Jun 20, 2022
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 20, 2022
@kwiatekus
Do not install rafter
fb286f4 
This reverts commit 877531f.
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 20, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 20, 2022
@kwiatekus kwiatekus removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2022
@kyma-bot kyma-bot merged commit 7d69bf5 into kyma-project:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelsayed moelsayed moelsayed approved these changes

@veichtj veichtj veichtj approved these changes

@cnvergence cnvergence cnvergence approved these changes

@piotrkpc piotrkpc Awaiting requested review from piotrkpc

@strekm strekm Awaiting requested review from strekm

@werdes72 werdes72 Awaiting requested review from werdes72

@mjakobczyk mjakobczyk Awaiting requested review from mjakobczyk

@dariusztutaj dariusztutaj Awaiting requested review from dariusztutaj

@m00g3n m00g3n Awaiting requested review from m00g3n

@pPrecel pPrecel Awaiting requested review from pPrecel

@dbadura dbadura Awaiting requested review from dbadura

@Cortey Cortey Awaiting requested review from Cortey

@fourthisle fourthisle Awaiting requested review from fourthisle

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@ruanxin ruanxin Awaiting requested review from ruanxin

@tobiscr tobiscr Awaiting requested review from tobiscr

@clebs clebs Awaiting requested review from clebs

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@jakobmoellerdev jakobmoellerdev Awaiting requested review from jakobmoellerdev

@adityabhatia adityabhatia Awaiting requested review from adityabhatia

Assignees

@moelsayed moelsayed

@veichtj veichtj

@cnvergence cnvergence

Labels
area/charts Issues or PRs related to changes in charts area/core-and-supporting Issues or PRs related to core and supporting area/installation Issues or PRs related to installation area/security Issues or PRs related to security area/service-mesh Issues or PRs related to service-mesh area/tests Issues or PRs related to tests lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kwiatekus @kyma-bot @pPrecel @moelsayed @veichtj @cnvergence